1490658 - Support RTCIceCandidate.usernameFragment

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Byron Campen [:bwc]]

Right now our ICE restart implementation is pretty fragile, because we might assign trickle candidates to the wrong ICE stream. usernameFragment is intended to make this possible.

Comment 1

[Paul Adenot (:padenot)]

Byron, it sounds like you're about to work on this, feel free to correct if my guess is wrong.

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd35759ba6fc2d8cdd399ae1b194973fbec48413

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1490658: (WIP) Support RTCIceCandidate.usernameFragment.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=69109e1a8cf68587ac1891d8dd80cfddd1662b8f

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fff72fce3931df9044c5e0369942763aacb9bcb8

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1490658: Support RTCIceCandidate.usernameFragment.

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=70ea1762f4dc

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=450dc9a72ded4b07131e856d05d68b91da967d2e

Comment 9

[Byron Campen [:bwc]]

Try push for gtest, since review feedback required touching gtest files.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=76c91ad63508

Comment 10

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a272c5cc4eea5829438831e66b5c02a9fb3b57c6

Comment 11

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e19b8d1263bc

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb3e31776e655a8c395403027aaa0d400253d800

Comment 13

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c09efe0ad1d&selectedJob=232457535

Comment 14

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d0683f101ed21a4212aa3bf8aacd90fe74c3b26

Comment 15

[Byron Campen [:bwc]]

Needed rebase:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03beddb89ee2

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/034dbb475f6d
Support RTCIceCandidate.usernameFragment. r=mjf,smaug

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/034dbb475f6d

Comment 18

[Chris Mills [:cmills]]

Note to MDN writers: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/67#Media_Web_Audio_and_WebRTC.

It looks like we already documented this. BCD needs updating, plus we could do with completing the page a bit more (e.g. example missing).

Comment 19

[Eric Shepherd [:sheppy]]

Yes, already documented. BCD update PR is pending: https://github.com/mdn/browser-compat-data/pull/4086

Comment 20

[Eric Shepherd [:sheppy]]

Also added an example to the article:

https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidate/usernameFragment