1491614 - Red text for download notification warnings should use --text-color-error

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Tim Nguyen :ntim]

(In reply to Amy Lee [:amylee] UX from bug 1468453 comment #13)
> Hi, 
> 
> The red we have in the photon palette doesn't pass contrast tests in Dark
> theme. I will mention this to the DSG team. In the meantime, my
> recommendation is to use the default text colour we have currently for
> downloads.

Comment 1

[Tim Nguyen :ntim]

This code needs to be removed:

https://searchfox.org/mozilla-central/rev/7a91966c106a3dde924e040b4e5b72d33eb77bf7/browser/themes/osx/downloads/downloads.css#28-35
https://searchfox.org/mozilla-central/rev/7a91966c106a3dde924e040b4e5b72d33eb77bf7/browser/themes/windows/downloads/downloads.css#31-38

Comment 2

[Vincent Cote (:vcote)]

Just looked at this with Paolo, we think it needs design input.

Comment 3

[Tim Nguyen :ntim]

Bug 1468453 comment #13 is exactly UX input here, not sure what else needs input here...

Comment 4

[:Paolo Amadini]

As far as I know, the red text for the malware case was an explicit design decision to convey the severity level of the threat. This doesn't work with the dark theme, and the way I read the recommendation in comment 1 is to use the default text color with dark themes, but make no changes to the current red color with the light theme.

Conversely, the fix suggestion in comment 1 would get rid of the red color for all themes, which I don't think is what we want here. Amy, is that correct?

Comment 5

[Amy Lee [:amylee] UX]

(In reply to :Paolo Amadini from comment #4)
> As far as I know, the red text for the malware case was an explicit design
> decision to convey the severity level of the threat. This doesn't work with
> the dark theme, and the way I read the recommendation in comment 1 is to use
> the default text color with dark themes, but make no changes to the current
> red color with the light theme.
> 
> Conversely, the fix suggestion in comment 1 would get rid of the red color
> for all themes, which I don't think is what we want here. Amy, is that
> correct?

Yes, please keep the red color for light/default theme

Comment 6

[:Paolo Amadini]

We also have similar red text in the Site Identity panel. It doesn't necessarily have to be handled in this bug, but the solution would probably be similar.

Comment 7

[komalbharadiya]

Hi Dão Gottwald,
I am Komal from Pune, India. I am novice to open source. But really interested to learn and contribute for this organization. Can I work on this issue? I need help, as to how do I go about it?
Thank you!

Comment 8

[Dão Gottwald [:dao]]

Sorry, Komal, but I don't think this issue is a good first bug.

Comment 9

[komalbharadiya]

Okay,No problems! Thanks!

Comment 10

[komalbharadiya]

*problem

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:dao, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 12

[Dão Gottwald [:dao]]

I'm not even sure if this bug is still happening. Can someone confirm? Something may have changed here in the last 5 years.

Comment 13

[:Gijs (he/him)]

Attachment: Screenshot 2023-12-11 at 22.05.18.png

STR:

1. open http://testsafebrowsing.appspot.com/
2. click the "Should show a "malicious" warning, based on content: link [W/M] " link under "Desktop Download warnings".

The colour adapts correctly in the default dark theme. It gets set here: https://searchfox.org/mozilla-central/rev/c003be8b9727672e7d30972983b375f4c200233f/browser/themes/shared/downloads/downloads.inc.css#78-80 .

I imagine it's not visible on custom themes, and it may need changes for HCM?

Comment 14

[:Gijs (he/him)]

Making this visible to triage while I'm here.

Comment 15

[Dão Gottwald [:dao]]

We should use --text-color-error from bug 1868412, it should work for most themes.

Comment 16

[Dão Gottwald [:dao]]

Attachment: Bug 1491614 - Red text for download notification warnings should use --text-color-error. r=mak

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeb89c4f4246
Red text for download notification warnings should use --text-color-error. r=desktop-theme-reviewers,sfoster

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/aeb89c4f4246