1530632 - Info panel - change color for the red Remember this Decision info text

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: infoColor.png

Affected versions

• 65.0.1, 66.0b6, 66.0b11, 67.0a1 (2019-02-25)

Affected platforms

• Windows 10, macOS 10.13

Steps to reproduce

1. Launch Firefox, set it to Dark Theme;
2. Access https://mozilla.github.io/webrtc-landing/gum_test.html
3. Click on the Screen test;
4. Click on the Remmember this decision checkbox;

Expected result

• The string is readable;

*Actual result

• Color theme setup makes it hard to read;

Regression range

• for the current regression range, the previous version had the panel's background color set to black ... which wasn't ideal either;
• First bad: 2018-04-09 17:33:45.385000
• Last good: 2018-04-09 17:07:57.689000
• Potential regressor: bug 1451947

Additional notes

• attached screenshot with the issue;
• on Ubuntu the color is set to the default one;

Comment 1

[Cristian Fogel [:cfogel]]

Hey NTim, mind taking a look at this when you got time?
Thanks!

Comment 2

[Johann Hofmann [:johannh]]

I feel like there's a dupe for this...

Comment 3

[Tim Nguyen :ntim]

I don't have time to look into this, sorry. Maybe Johann can ?

Comment 4

[Johann Hofmann [:johannh]]

Yes I can, this sounds like a good bug to mentor. We should probably use the same red that we use for the "insecure connection" text in the identity popup (go to http://example.com/ and click the (i) in the location bar).

Finding the colors and source files to modify is left as an exercise (though feel free to ask me if you're stuck).

It will likely involve the Browser Toolbox and Searchfox

Thanks!

Comment 5

[Carolina Jimenez Gomez]

can I work on it?

Comment 6

[Carolina Jimenez Gomez]

Attachment: Bug 1530632 - Change popup notification warning color (linux, osx and windows) to the one use in .identity-popup-connection-not-secure r=johannh

Comment 7

[Johann Hofmann [:johannh]]

I've given you editbugs access, so you can set your own checkin-needed now :)

Comment 8

[Carolina Jimenez Gomez]

where should I do it? I don't see the place to put it...

Comment 9

[Tim Nguyen :ntim]

In the whiteboard field (inside the details section), you can type "checkin-needed".

Comment 10

[Johann Hofmann [:johannh]]

I'll do it, it's in the "keywords" field (not "whiteboard").

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a16d8a7b8a30
Change popup notification warning color (linux, osx and windows) to the one use in .identity-popup-connection-not-secure r=johannh

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a16d8a7b8a30

Comment 13

[Cristian Fogel [:cfogel]]

Verified with 67.0a1 (2019-03-05).