1491749 - Stop using xul:keyset and xul:key in toolbox-window.xul

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Developer Tools Toolbox is still using <xul:keyset> and <xul:key> elements to handle keyboard shortcuts. These should be removed (as part xul-removal effor) and replaced by KeyShortcuts object from "devtools/client/shared/key-shortcuts".

See also Bug 1488915 and this patch:
https://phabricator.services.mozilla.com/D5255#inline-19592

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b5bdb344c8e41a89af4142e067e77cfa40159b0

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1491749 - Stop using xul:keyset and xul:key in toolbox-window.xul; r=bgrins

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=901d6afb63208f374cd4c8810e5c114b44072f5d

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 9009570 [details]
Bug 1491749 - Stop using xul:keyset and xul:key in toolbox-window.xul; r=bgrins

Francesco Lodolo [:flod] has approved the revision.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bedb3f2b986523d6c264f5ff0b1b97c31363ded8

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ee97e0dc20a166ee031460a4ab4fe181e45a725

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 9009570 [details]
Bug 1491749 - Stop using xul:keyset and xul:key in toolbox-window.xul; r=bgrins

Brian Grinstead [:bgrins] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c61662006c89
Stop using xul:keyset and xul:key in toolbox-window.xul; r=bgrins,flod

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c61662006c89