1491808 - [CSD][Wayland] Titlebar looks inactive when the main windows is dragged

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

There's a small regression from Bug #1442755

When Firefox main window is dragged, the titlebar and elements there are painted as inactive.

Comment 1

[Alexander Browne]

This may need its own bug, but similarly in MATE the Firefox main window looks inactive when there is an OSD on the screen, such as when changing the volume or brightness using the keyboard buttons and when using Alt+Tab. Other apps (CSD and non-CSD) don't do this. I tried Xfce and Gnome, and it looks like it works OK there, so this may also be a MATE/Marco bug.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I can reproduce that on gnome-shell with Ubuntu Ambiance theme.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

(In reply to Alexander Browne from comment #1)
> This may need its own bug, but similarly in MATE the Firefox main window
> looks inactive when there is an OSD on the screen, such as when changing the
> volume or brightness using the keyboard buttons and when using Alt+Tab.
> Other apps (CSD and non-CSD) don't do this. I tried Xfce and Gnome, and it
> looks like it works OK there, so this may also be a MATE/Marco bug.

Firefox titlebar reacts on focus change so it may be caused by this.

Also, I can't reproduce this one with latest trunk, co closing for now.

Comment 4

[Alexander Browne]

I still see it in Ubuntu MATE with the latest nightly, but I think it's a MATE/Marco issue.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Hm, it's here again - Fedora 29/gnome-shell.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

I can reliably reproduce that on Wayland builds only.

Comment 7

[Alexander Browne]

FWIW it's fixed (as of a week ago I'd say) on Ubuntu MATE (18.10 at least) when using OSD.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

(In reply to Alexander Browne from comment #7)
> FWIW it's fixed (as of a week ago I'd say) on Ubuntu MATE (18.10 at least)
> when using OSD.

Thanks, marking as Wayland only then as I can reproduce it only there.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Seems to be caused by focus-out even which is sent to main window when it's dragged. I see that on gnome-shell only, Weston doesn't send that.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Reported upstream as https://gitlab.gnome.org/GNOME/gtk/issues/1395
It's Mutter/Wayland specific issue, works fine in X11/Weston.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

It's going to be addressed in Bug 1497534.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

The bug is still here - it would need more investigation to fix that properly. Firefox 64 is not affected as Bug 1442755 was backed out (disabled) for Beta.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Looks like the moz_gtk_header_bar_paint() may be called before the GTK_STATE_FLAG_BACKDROP state flag is set at mShell window - it's a race condition.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1491808 - Listen on window-state-event to set titlebar active/inactive state, r=jhorak

This is a workaround for https://gitlab.gnome.org/GNOME/gtk/issues/1395
Gtk+ controls window active appearance by window-state-event signal
but gecko uses focus-in/out signals.

So we need to set the the titlebar state
when window-state-event comes *after* focus-in/out signals.

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1491808 - [Linux/CSD/Titlebar] Force toplevel window repaint when titlebar rendering is enabled and its state changes, r=bzbarsky

Titlebar (StyleAppearance::MozWindowTitlebar) style depends on toplevel window focus
and we need to redraw it when toplevel window focus changes.

Unfortunately according to https://gitlab.gnome.org/GNOME/gtk/issues/1395
the toplevel window focus can't be used here as we can have active but unfocused
toplevel window during drag & drop.

Gtk+ controls window active appearance by window-state-event signal
but gecko uses focus-in/out signals, so we need to repaint the titlebar
when window-state-event comes *after* focus-in/out signals.

We can't call mWidgetListener->WindowActivated() (and WindowDeactivated())
as it was already called from focus-in/out handlers before window-state-event.

Depends on D13051

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1fc8c77ad7f
Listen on window-state-event to set titlebar active/inactive state, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/1a6f9251c41f
[Linux/CSD/Titlebar] Force toplevel window repaint when titlebar rendering is enabled and its state changes, r=bzbarsky

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d1fc8c77ad7f
https://hg.mozilla.org/mozilla-central/rev/1a6f9251c41f