1497534 - Titlebar loses active appearance during drag and drop operations

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Kestrel]

Attachment: titlebar-inactive-tab-drag.png

Moving a tab by dragging it with the mouse causes the titlebar to lose active appearance. This is a regression caused by Bug 1442755 and does not happen with other applications like Nautilus, gedit and Chromium. This behavior might be expected when the tab is dragged outside the tab strip to create a new window but not when remaining inside the tab strip.

Comment 1

[Jason Duell]

Martin you landed bug 1442755

Comment 2

[Kestrel]

This is not limited to tab dragging, all drag and drop operations are affected.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Kestrel, which system do you run? I can't reproduce that on Fedora 29/Gtk+ 3.24.

Comment 4

[Kestrel]

Ubuntu 18.04 is affected.
Ubuntu 16.04 LTS is unaffected.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Okay, I'll try that.

Comment 6

[Kestrel]

Ubuntu 18.10 is unaffected (GTK+ 3.24.1).
The affected Ubuntu 18.04.1 LTS uses GTK+ 3.22.30.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

This seems to be a variant of Bug 1491808. I can reproduce that on Ubuntu 18.04. We may base our window inactive state on the backdrop property of toplevel window instead of the focus.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1497534 - Check Gtk backdrop state flag to make Firefox toplevel window look inactive, r=jhorak

Comment 9

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4bd40102d3f8dad460882758fa1df15fe952201

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1715e7443b8
Check Gtk backdrop state flag to make Firefox toplevel window look inactive, r=jhorak

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c1715e7443b8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider backporting to Beta? It grafts cleanly as-landed.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Let's consider that after some time at nightly.

Comment 15

[Martin Stránský [:stransky] (ni? me)]

I think we rather disable Bug 1442755 for Beta as it reveals more are regressions (Bug 1506050 recently).

Comment 16

[Oana Botisan, Desktop QA]

I can't seem to reproduce the issue. I used an older version of Nightly (2018-10-09) on Ubuntu 18.04.1 x64, but the title didn't appear inactive. I got the same result from the latest Nightly 66.0a1 and beta 65.0b9 as I got from the older version of Nightly.

Can you please make a screen cast or give me some additional info?

Comment 17

[Martin Stránský [:stransky] (ni? me)]

(In reply to Oana Botisan from comment #16)

Can you please make a screen cast or give me some additional info?

You need to disable system titlebar to reproduce it, at Customize menu -> Titlebar checkbox.

Comment 18

[Oana Botisan, Desktop QA]

I managed to reproduce the issue on an older Nightly from 2018-10-09 on Ubuntu 18.04.1. I didn't see before where exactly the bar lost it's active appearance, but I finally notice that the browser controls were greyed out.
I retested everything using the latest Nightly 67.0a1, Firefox 66.0b5 and Firefox 65.0 on the same platform. The bug is not reproducing anymore.