Titlebar loses active appearance during drag and drop operations

VERIFIED FIXED in Firefox 65

Status

()

defect
P1
normal
VERIFIED FIXED
7 months ago
3 months ago

People

(Reporter: ke5trel, Assigned: stransky)

Tracking

(Blocks 1 bug, {regression})

64 Branch
mozilla65
Unspecified
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox62 unaffected, firefox63 unaffected, firefox64 unaffected, firefox65 verified, firefox66 verified, firefox67 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

7 months ago
Moving a tab by dragging it with the mouse causes the titlebar to lose active appearance. This is a regression caused by Bug 1442755 and does not happen with other applications like Nautilus, gedit and Chromium. This behavior might be expected when the tab is dragged outside the tab strip to create a new window but not when remaining inside the tab strip.

Comment 1

6 months ago
Martin you landed bug 1442755
Flags: needinfo?(stransky)
(Reporter)

Comment 2

6 months ago
This is not limited to tab dragging, all drag and drop operations are affected.
Summary: Titlebar loses active appearance when tab dragged inside tab strip → Titlebar loses active appearance during drag and drop operations
(Assignee)

Comment 3

6 months ago
Kestrel, which system do you run? I can't reproduce that on Fedora 29/Gtk+ 3.24.
Flags: needinfo?(stransky) → needinfo?(ke5trel)
(Assignee)

Updated

6 months ago
Assignee: nobody → stransky
(Reporter)

Comment 4

6 months ago
Ubuntu 18.04 is affected.
Ubuntu 16.04 LTS is unaffected.
Flags: needinfo?(ke5trel)
(Assignee)

Comment 5

6 months ago
Okay, I'll try that.
(Reporter)

Comment 6

6 months ago
Ubuntu 18.10 is unaffected (GTK+ 3.24.1).
The affected Ubuntu 18.04.1 LTS uses GTK+ 3.22.30.

Updated

6 months ago
Priority: -- → P1
(Assignee)

Comment 7

6 months ago
This seems to be a variant of Bug 1491808. I can reproduce that on Ubuntu 18.04. We may base our window inactive state on the backdrop property of toplevel window instead of the focus.
(Assignee)

Updated

6 months ago
Duplicate of this bug: 1491808
(Assignee)

Updated

6 months ago
Keywords: checkin-needed

Comment 11

6 months ago
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1715e7443b8
Check Gtk backdrop state flag to make Firefox toplevel window look inactive, r=jhorak
Keywords: checkin-needed

Comment 12

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c1715e7443b8
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Is this something we should consider backporting to Beta? It grafts cleanly as-landed.
(Assignee)

Comment 14

6 months ago
Let's consider that after some time at nightly.
Flags: needinfo?(stransky)
(Reporter)

Updated

6 months ago
Depends on: 1506050
(Assignee)

Comment 15

6 months ago
I think we rather disable Bug 1442755 for Beta as it reveals more are regressions (Bug 1506050 recently).
Flags: needinfo?(stransky)
Flags: qe-verify+

I can't seem to reproduce the issue. I used an older version of Nightly (2018-10-09) on Ubuntu 18.04.1 x64, but the title didn't appear inactive. I got the same result from the latest Nightly 66.0a1 and beta 65.0b9 as I got from the older version of Nightly.

Can you please make a screen cast or give me some additional info?

Flags: needinfo?(stransky)
(Assignee)

Comment 17

4 months ago

(In reply to Oana Botisan from comment #16)

Can you please make a screen cast or give me some additional info?

You need to disable system titlebar to reproduce it, at Customize menu -> Titlebar checkbox.

Flags: needinfo?(stransky)

I managed to reproduce the issue on an older Nightly from 2018-10-09 on Ubuntu 18.04.1. I didn't see before where exactly the bar lost it's active appearance, but I finally notice that the browser controls were greyed out.
I retested everything using the latest Nightly 67.0a1, Firefox 66.0b5 and Firefox 65.0 on the same platform. The bug is not reproducing anymore.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.