Closed Bug 1492925 Opened 6 years ago Closed 6 years ago

Fix shared surfaces leak when a pipeline is removed

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(1 file)

0001-Bug-1492925-Ensure-we-release-the-shared-surfaces-wh.patch, v1
1.40 KB, patch
sotaro
: review+
Details | Diff | Splinter Review
In AsyncImagePipelineManager::ProcessPipelineRemoved, we need to explicitly release the shared surfaces like in AsyncImagePipelineManager::ProcessPipelineRendered. Otherwise they remain mapped in the GPU process memory.
Assignee: nobody → aosmond
Blocks: 1378528
Status: NEW → ASSIGNED
Priority: -- → P1
Blocks: stage-wr-trains
Comment on attachment 9010725 [details] [diff] [review] 0001-Bug-1492925-Ensure-we-release-the-shared-surfaces-wh.patch, v1 Looks good!
Attachment #9010725 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0e28dd357396 Ensure we release the shared surfaces when a WebRender pipeline is removed. r=sotaro
https://hg.mozilla.org/mozilla-central/rev/0e28dd357396
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1493429
See Also: → 1501925
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: