Fix shared surfaces leak when a pipeline is removed

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: aosmond, Assigned: aosmond)

Tracking

(Blocks 1 bug)

Trunk
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

8 months ago
In AsyncImagePipelineManager::ProcessPipelineRemoved, we need to explicitly release the shared surfaces like in AsyncImagePipelineManager::ProcessPipelineRendered. Otherwise they remain mapped in the GPU process memory.
Assignee

Updated

8 months ago
Assignee: nobody → aosmond
Blocks: 1378528
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 9010725 [details] [diff] [review]
0001-Bug-1492925-Ensure-we-release-the-shared-surfaces-wh.patch, v1

Looks good!
Attachment #9010725 - Flags: review?(sotaro.ikeda.g) → review+

Comment 3

8 months ago
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e28dd357396
Ensure we release the shared surfaces when a WebRender pipeline is removed. r=sotaro

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0e28dd357396
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
See Also: → 1501925
You need to log in before you can comment on or make changes to this bug.