1493429 - Assertion failure: released, at /builds/worker/workspace/build/src/gfx/layers/wr/AsyncImagePipelineManager.cpp:630

Status: RESOLVED DUPLICATE of bug 1492930

(Core :: Graphics: WebRender, defect, P2)

Description

[Darkspirit]

(Jan Andre Ikenmeyer [:darkspirit] from bug 1493177 comment 18)
> (In reply to Ludovic Hirlimann [:Usul] from bug 1493177 comment 17)
> > I've managed to reproduce using youtube. Seeking a video once or twice and then pausing it. Unpause and boom.
> 
> I've tried that and resizing the window and got a different crash reason than you. But I haven't managed to reproduce it again.
> 
> RUST_BACKTRACE=1 mozregression --launch 2018-09-21 -B debug --pref gfx.webrender.all:true -a https://www.youtube.com/watch?v=XxP8kxUn5bc
> > Assertion failure: released, at /builds/worker/workspace/build/src/gfx/layers/wr/AsyncImagePipelineManager.cpp:630
> 
> The assertion has been added by bug 1492925 [...]

https://searchfox.org/mozilla-central/rev/21588b2a9824e0758fe11d10065e2c01ea9f32be/gfx/layers/wr/AsyncImagePipelineManager.cpp#628-630
> DebugOnly<bool> released = SharedSurfacesParent::Release(holder->mExternalImages.front().mImageId);
> MOZ_ASSERT(released);

I'll try to find better/working STR.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

When I was writing memory reporting, I suspect there was a bug related to content process shutdown. When the process gets destroyed, I release all the buffers that it didn't, but it really should only do that if the content process didn't release its own handle... in theory if it did do that, it could fail to release when the pipeline manager wants to purge its own list. It probably would show up like an end result like this.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

This should be fixed in bug 1492930, as part of

https://hg.mozilla.org/mozilla-central/rev/df5f3e347750

Which prevents the double free from the content process shutdown. Please reopen if you see the assert with builds containing the above change.

Comment 3

[Darkspirit]

Oh, nice, thanks!