1501925 - Simplify forwarding textures handling in AsyncImagePipelineManager

Status: RESOLVED DUPLICATE of bug 1503498

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

ForwardingExternalImage, ForwardingTextureHostWrapper and ForwardingTextureHost do almost same thing. It is better to simplify it.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify forwarding textures handling in AsyncImagePipelineManager

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify forwarding textures handling in AsyncImagePipelineManager

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify forwarding textures handling in AsyncImagePipelineManager

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify forwarding textures handling in AsyncImagePipelineManager

fix build problem.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Simplify forwarding textures handling in AsyncImagePipelineManager

Comment 6

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e264f77aee7e7441aa73a775a630727161a88bdc

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 9020301 [details] [diff] [review]
patch - Simplify forwarding textures handling in AsyncImagePipelineManager

Review of attachment 9020301 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the review lag. In general I actually prefer to have separate list of concrete types than a single list of abstract classes because it's terribly cache unfriendly, and the added abstraction layer turns out to be an obstacle later.
I am sure that in this situation the performance isn't noticeably affected but it's the sum of many very small things like that that contribute to overall hard to address performance issues.

Comment 8

[Sotaro Ikeda [:sotaro]]

Replaced by Bug 1503498.