Closed
Bug 1501925
Opened 6 years ago
Closed 6 years ago
Simplify forwarding textures handling in AsyncImagePipelineManager
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
DUPLICATE
of bug 1503498
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 4 obsolete files)
ForwardingExternalImage, ForwardingTextureHostWrapper and ForwardingTextureHost do almost same thing. It is better to simplify it.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
Summary: Simplify forwarding texture handling in AsyncImagePipelineManager → Simplify forwarding textures handling in AsyncImagePipelineManager
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #9020226 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Attachment #9020301 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e264f77aee7e7441aa73a775a630727161a88bdc
Comment 7•6 years ago
|
||
Comment on attachment 9020301 [details] [diff] [review] patch - Simplify forwarding textures handling in AsyncImagePipelineManager Review of attachment 9020301 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the review lag. In general I actually prefer to have separate list of concrete types than a single list of abstract classes because it's terribly cache unfriendly, and the added abstraction layer turns out to be an obstacle later. I am sure that in this situation the performance isn't noticeably affected but it's the sum of many very small things like that that contribute to overall hard to address performance issues.
Assignee | ||
Updated•6 years ago
|
Attachment #9020301 -
Flags: review?(nical.bugzilla)
Assignee | ||
Comment 8•6 years ago
|
||
Replaced by Bug 1503498.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•