Closed Bug 1493057 Opened 5 years ago Closed 5 years ago
Make sure test
_ext _privacy .js doesn't depend on the default value of the network .cookie .cookie Behavior preference
Bug 1493057 - Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference
46 bytes, text/x-phabricator-request
|Details | Review|
No description provided.
I know that this is doing part of what bug 1487297 was doing, but I need this to be able to enable the third-party cookie blocking feature on Nightly (in order to appease test_ext_privacy.js.
Comment on attachment 9010834 [details] Bug 1493057 - Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference Luca Greco [:rpl] has approved the revision.
Attachment #9010834 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9a99305d2fcb Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference r=rpl
This is a change in the public-facing API and needs to be documented at: - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/websites#Properties Also the fact that this change is Firefox-only needs to be reflected in the browser compatibility tables at - https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/websites#Browser_compatibility which is derived from this source: - https://github.com/mdn/browser-compat-data/blob/b0dc0d3e530ab21e474608a062c28b290a6356c8/webextensions/api/privacy.json Is this API final (considering bug 1487297)? If yes, please add the dev-doc-needed keyword so that the documentation gets updated.
You're right, my bad.
Note to documentation team: I have added a note to the 64 rel notes to cover this: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#Changes_for_add-on_developers And added the new value to the privacy.websites page: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/websites But the other tasks still need doing. Feel free to update my notes if I've got this wrong.
You need to log in before you can comment on or make changes to this bug.