Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference

RESOLVED FIXED in Firefox 64

Status

defect
RESOLVED FIXED
9 months ago
7 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({dev-doc-needed})

unspecified
mozilla64
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

9 months ago
No description provided.
Assignee

Comment 1

9 months ago
I know that this is doing part of what bug 1487297 was doing, but I need this to be able to enable the third-party cookie blocking feature on Nightly (in order to appease test_ext_privacy.js.
Blocks: 1492563
See Also: → 1487297

Comment 3

9 months ago
Comment on attachment 9010834 [details]
Bug 1493057 - Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference

Luca Greco [:rpl] has approved the revision.
Attachment #9010834 - Flags: review+

Comment 4

9 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a99305d2fcb
Make sure test_ext_privacy.js doesn't depend on the default value of the network.cookie.cookieBehavior preference r=rpl

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9a99305d2fcb
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

Updated

9 months ago
Flags: qe-verify-

Comment 6

9 months ago
This is a change in the public-facing API and needs to be documented at:
- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/websites#Properties

Also the fact that this change is Firefox-only needs to be reflected in the browser compatibility tables at
- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/websites#Browser_compatibility
which is derived from this source:
- https://github.com/mdn/browser-compat-data/blob/b0dc0d3e530ab21e474608a062c28b290a6356c8/webextensions/api/privacy.json

Is this API final (considering bug 1487297)? If yes, please add the dev-doc-needed keyword so that the documentation gets updated.
Flags: needinfo?(ehsan)
Assignee

Comment 7

9 months ago
You're right, my bad.
Flags: needinfo?(ehsan)
Keywords: dev-doc-needed
Duplicate of this bug: 1487297
Note to documentation team:

I have added a note to the 64 rel notes to cover this:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#Changes_for_add-on_developers

And added the new value to the privacy.websites page:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/websites

But the other tasks still need doing. Feel free to update my notes if I've got this wrong.
You need to log in before you can comment on or make changes to this bug.