Closed Bug 1493374 Opened 2 years ago Closed 2 years ago

Port bug 1493220: changed mozIOSPreferences API

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1493313 +++

regionalPrefsLocales
https://dxr.mozilla.org/comm-central/search?q=etRegionalPrefsLocales++++++path%3Acomm%2F&redirect=false

Replace
  osprefs.getRegionalPrefsLocales()[0];
with
  osprefs.regionalPrefsLocales[0];

Three call sites. I think we don't use OSPreferences.systemLocales:
https://dxr.mozilla.org/comm-central/search?q=etSystemLocales+++++path%3Acomm%2F&redirect=false
But there ise:
https://dxr.mozilla.org/comm-central/search?q=ystemLocales+++++path%3Acomm%2F&redirect=false
which I think don't need treatment.

See announcement here:
https://groups.google.com/d/msg/mozilla.dev.platform/csDd-PFftLg/hOXKXpm4CgAJ
This might do it, hard to tell before seeing the final version of bug 1493220.
Attachment #9011181 - Flags: review?(makemyday)
Attachment #9011181 - Flags: review?(acelists)
Severity: critical → normal
Component: Testing Infrastructure → General
Comment on attachment 9011181 [details] [diff] [review]
1493374-regionalPrefsLocales.patch

Review of attachment 9011181 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #9011181 - Flags: review?(makemyday) → review+
Comment on attachment 9011181 [details] [diff] [review]
1493374-regionalPrefsLocales.patch

Review of attachment 9011181 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thanks.
Attachment #9011181 - Flags: review?(acelists) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/86e1a9121b5d
Port bug 1493220: Replace getRegionalPrefsLocales() with regionalPrefsLocales. r=aceman,MakeMyDay DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.