1493401 - Crash in webrender::clip::add_clip_node_to_current_chain

Status: RESOLVED WONTFIX

(Core :: Graphics: WebRender, defect, P4)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-4fe46587-ce7b-4b51-8c1f-5e3e60180921.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll static bool webrender::clip::add_clip_node_to_current_chain gfx/webrender/src/clip.rs:1223
1 xul.dll static union core::option::Option<webrender::clip::ClipChainInstance> webrender::clip::ClipStore::build_clip_chain_instance gfx/webrender/src/clip.rs:483
2 xul.dll static bool webrender::prim_store::PrimitiveStore::prepare_prim_for_render gfx/webrender/src/prim_store.rs:1713
3 xul.dll static void webrender::prim_store::PrimitiveStore::prepare_prim_runs gfx/webrender/src/prim_store.rs:1896
4 xul.dll static bool webrender::prim_store::PrimitiveStore::prepare_prim_for_render gfx/webrender/src/prim_store.rs:1633
5 xul.dll static void webrender::prim_store::PrimitiveStore::prepare_prim_runs gfx/webrender/src/prim_store.rs:1896
6 xul.dll static bool webrender::prim_store::PrimitiveStore::prepare_prim_for_render gfx/webrender/src/prim_store.rs:1633
7 xul.dll static void webrender::prim_store::PrimitiveStore::prepare_prim_runs gfx/webrender/src/prim_store.rs:1896
8 xul.dll static bool webrender::prim_store::PrimitiveStore::prepare_prim_for_render gfx/webrender/src/prim_store.rs:1633
9 xul.dll static void webrender::prim_store::PrimitiveStore::prepare_prim_runs gfx/webrender/src/prim_store.rs:1896

=============================================================

There are 4 crashes (from 4 installations) in nightly 64 with buildid 20180921100113. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1492566.

[1] https://hg.mozilla.org/mozilla-central/rev?node=14c6b338e32c

Comment 1

[Darkspirit]

> 0 xul.dll static bool webrender::clip::add_clip_node_to_current_chain gfx/webrender/src/clip.rs:1223

https://hg.mozilla.org/mozilla-central/annotate/8b93a94b92c361e3a2e498bfdd7e7605cd8f7b5e/gfx/webrender/src/clip.rs#l1223
has been modified by
https://github.com/servo/webrender/pull/3075

Comment 2

[Maire Reavy [:mreavy]]

Jeff, Glenn -- is this bug actionable?

Comment 3

[Glenn Watson [:gw]]

Not without a repro, unfortunately. It seems to be accessing in invalid handle somehow - but this should (in theory) not be possible, so we'll need a way to reproduce it to see what is going on. It seems to have really dropped off in the crashes graph above though?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

The volume here is really low. Closing for now.