1493968 - Intermittent devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | A promise chain failed to handle a rejection: Connection closed, pending error from root, type listTabs failed - stack: _queueResponse/responsePromise

Reporter

Description

•

6 years ago

treeherder

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=201416906&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/Nq_-um9ARPm_KiO1PY32zw/runs/0/artifacts/public/logs/live_backing.log

12:39:58     INFO - TEST-START | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js
12:39:58     INFO - GECKO(8100) | console.error: "ADB extension is not installed"
12:39:58     INFO - GECKO(8100) | JavaScript error: resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js, line 1590: Error: Connection closed, pending error from root, type listTabs failed
12:39:58     INFO - TEST-INFO | started process screenshot
12:39:58     INFO - TEST-INFO | screenshot: exit 0
12:39:58     INFO - Buffered messages logged at 12:39:58
12:39:58     INFO - Entering test bound 
12:39:58     INFO - Force all debug target panes to be expanded
12:39:58     INFO - opening about:debugging
12:39:58     INFO - Adding a new tab with URL: about:debugging
12:39:58     INFO - Tab added and finished loading
12:39:58     INFO - Wait until the main about debugging container is available
12:39:58     INFO - Wait until the client connection was established
12:39:58     INFO - TEST-PASS | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | Found the Connect sidebar item - 
12:39:58     INFO - TEST-PASS | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | Found the ThisFirefox sidebar item - 
12:39:58     INFO - TEST-PASS | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | ThisFirefox sidebar item is selected by default - 
12:39:58     INFO - Open a new background tab TAB1
12:39:58     INFO - Adding a new tab with URL: data:text/html,<title>TAB1</title>
12:39:58     INFO - Tab added and finished loading
12:39:58     INFO - Wait for the tab to appear in the debug targets with the correct name
12:39:58     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<title>TAB1</title>" line: 0}]
12:39:58     INFO - Click on the Connect item in the sidebar
12:39:58     INFO - Wait until Connect page is displayed
12:39:58     INFO - TEST-PASS | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | Connect sidebar item is selected - 
12:39:58     INFO - TEST-PASS | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | Runtime page no longer rendered - 
12:39:58     INFO - Open a new tab which should be listed when we go back to This Firefox
12:39:58     INFO - Adding a new tab with URL: data:text/html,<title>TAB2</title>
12:39:58     INFO - Console message: [JavaScript Error: "Error: Connection closed, pending error from root, type listTabs failed" {file: "resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js" line: 1590}]
12:39:58     INFO - Tab added and finished loading
12:39:58     INFO - Click on the ThisFirefox item in the sidebar
12:39:58     INFO - Wait until ThisFirefox page is displayed
12:39:58     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "data:text/html,<title>TAB2</title>" line: 0}]
12:39:58     INFO - TEST-PASS | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | ThisFirefox sidebar item is selected again - 
12:39:58     INFO - TEST-PASS | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | Connect page no longer rendered - 
12:39:58     INFO - TAB2 should already be displayed in the debug targets
12:39:58     INFO - Remove first background tab
12:39:58     INFO - Removing tab.
12:39:58     INFO - Waiting for event: 'TabClose' on [object XULElement].
12:39:58     INFO - Got event: 'TabClose' on [object XULElement].
12:39:58     INFO - Tab removed and finished closing
12:39:58     INFO - Check TAB1 disappears, meaning ThisFirefox client is correctly connected
12:39:58     INFO - Remove second background tab
12:39:58     INFO - Removing tab.
12:39:58     INFO - Waiting for event: 'TabClose' on [object XULElement].
12:39:58     INFO - Got event: 'TabClose' on [object XULElement].
12:39:58     INFO - Tab removed and finished closing
12:39:58     INFO - Check TAB2 disappears, meaning ThisFirefox client is correctly connected
12:39:58     INFO - Removing tab.
12:39:58     INFO - Waiting for event: 'TabClose' on [object XULElement].
12:39:58     INFO - Got event: 'TabClose' on [object XULElement].
12:39:58     INFO - Tab removed and finished closing
12:39:58     INFO - Buffered messages finished
12:39:58     INFO - TEST-UNEXPECTED-FAIL | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | A promise chain failed to handle a rejection: Connection closed, pending error from root, type listTabs failed - stack: _queueResponse/responsePromise<@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1590:15
12:39:58     INFO - promise callback*_queueResponse@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1588:8
12:39:58     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1727:7
12:39:58     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
12:39:58     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
12:39:58     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
12:39:58     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
12:39:58     INFO - _sendRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:708:7
12:39:58     INFO - _attemptNextRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:743:5
12:39:58     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:831:5
12:39:58     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
12:39:58     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
12:39:58     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
12:39:58     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
12:39:58     INFO - _queueResponse/responsePromise<@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1587:7
12:39:58     INFO - promise callback*_queueResponse@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1579:8
12:39:58     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1727:7
12:39:58     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
12:39:58     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
12:39:58     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
12:39:58     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
12:39:58     INFO - _sendRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:708:7
12:39:58     INFO - _attemptNextRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:743:5
12:39:58     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:831:5
12:39:58     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
12:39:58     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
12:39:58     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
12:39:58     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
12:39:58     INFO - _queueResponse/responsePromise<@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1587:7
12:39:58     INFO - promise callback*_queueResponse@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1579:8
12:39:58     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1727:7
12:39:58     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
12:39:58     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
12:39:58     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
12:39:58     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
12:39:58     INFO - Rejection date: Tue Sep 25 2018 12:39:58 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257
12:39:58     INFO - Stack trace:
12:39:58     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:257
12:39:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1127
12:39:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1093
12:39:58     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:990
12:39:58     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
12:39:58     INFO - Leaving test bound 
12:39:58     INFO - GECKO(8100) | MEMORY STAT | vsize 1791MB | vsizeMaxContiguous 132464598MB | residentFast 338MB | heapAllocated 173MB

Narcis Beleuzu [:NarcisB]

Comment 1

•

6 years ago

Julian, this fail is caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1489224.
Can you please take a look?

Flags: needinfo?(jdescottes)

Julian Descottes [:jdescottes]

Assignee

Comment 2

•

6 years ago

(In reply to Narcis Beleuzu [:NarcisB] from comment #1)
> Julian, this fail is caused by
> https://bugzilla.mozilla.org/show_bug.cgi?id=1489224.
> Can you please take a look?

I think this is rather Bug 1489222 (I landed both bugs with the same push, but the failing test here was added in Bug 1489222). 
I will take a look.

Flags: needinfo?(jdescottes)

Tiberius Oros[:tiberius_oros]

Updated

•

6 years ago

Summary: Intermittent [TV] devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | A promise chain failed to handle a rejection: Connection closed, pending error from root, type listTabs failed - stack: _queueResponse/responsePromise → Intermittent devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | A promise chain failed to handle a rejection: Connection closed, pending error from root, type listTabs failed - stack: _queueResponse/responsePromise

Julian Descottes [:jdescottes]

Assignee

Updated

•

6 years ago

Assignee: nobody → jdescottes

Blocks: 1489222

Status: NEW → ASSIGNED

Priority: P5 → P2

Marco Mucci [:MarcoM]

Updated

•

6 years ago

Blocks: remote-debugging-ng-m1

Priority: P2 → P1

Julian Descottes [:jdescottes]

Assignee

Comment 3

•

6 years ago

This issue is a race condition between two concurrent "listTabs" requests. The second request finishes after we navigated to the Connect page and already destroyed our runtime client. Therefore the transport is destroyed and we throw at 

https://searchfox.org/mozilla-central/rev/ce57be88b8aa2ad03ace1b9684cd6c361be5109f/devtools/server/main.js#1589-1592

There is a valid question to be asked here: I am not sure throwing here makes any sense. I think it is acceptable that pending requests cannot terminate correctly if the DevTools client was destroyed before getting the response. Otherwise the client should make sure to "cancel" such requests when it is destroyed. I don't think anyone can do anything with this error, so a console .log might be more appropriate.

Now for the immediate issue here, about:debugging can ask for the list of tabs in two scenarios:
- when connecting to a new runtime and retrieving the initial list of tabs
- when notified that the tabs list changed for the runtime we monitor, and we retrieve the list again

The test does the following steps:
- load about:aboutdebugging
- wait for the runtime page to appear
- load a new tab TAB1
- wait for TAB1 to appear in the list of targets
- navigate to the connect page
(... + other steps but irrelevant here)

Normally we expect TAB1 to be discovered by the second type of listTab calls, ie when the tabs list changes. However, our watchRuntime action is not waiting until it discovered tabs to terminate: https://searchfox.org/mozilla-central/rev/ce57be88b8aa2ad03ace1b9684cd6c361be5109f/devtools/client/aboutdebugging-new/src/actions/runtimes.js#103-124 . As you can see, we dispatch "WATCH_RUNTIME_SUCCESS" in the middle of the action (which will lead to displaying the runtime page) and then we request for tabs in the background. 

So under some conditions, the first listTabs call coming from the watchRuntime action might already discover TAB1. That means that "wait for TAB1 to appear in the list of targets" resolves immediately and we might close the connection before we processed the second listTabs call. 

In a good run we have

- load about:aboutdebugging
  ==> call watchRuntime for this firefox and retrieve list of tabs
- wait for the runtime page to appear
  <== connection to this firefos runtime established
  <== tabs retrieved
- load a new tab TAB1
  <== receiving TABS_UPDATED event
- wait for TAB1 in targets
  ==> retrieve list of tabs
  <== tabs retrieved
- navigate to the connect page
  ==> destroy the client, no pending connection

In a bad run however

- load about:aboutdebugging
  ==> call watchRuntime for this firefox and retrieve list of tabs
- wait for the runtime page to appear
  <== connection to this firefos runtime established
  (... tabs not retrieved yet)
- load a new tab TAB1
  <== tabs retrieved (including TAB1)
  <== receiving TABS_UPDATED event
  ==> retrieve list of tabs
- wait for TAB1 in targets
  (... TAB1 already displayed, moving directly to next step)
- navigate to the connect page
  ==> destroy the client
  <== response for listTabs comes back but client was destroyed

Several measures we can take to address this:
- stop throwing on transport issues
- only navigate to runtime page when initial debug targets are retrieved
- dispatch another action when the watchRuntime is fully finished and update the ui
- wait for initial tab targets to be displayed in the page before adding tab1

The simplest here is the last one because it only impacts the test, but we should discuss the other options in follow up bugs.

Julian Descottes [:jdescottes]

Assignee

Comment 4

•

6 years ago

Attached file Bug 1493968 - Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke — Details

Julian Descottes [:jdescottes]

Assignee

Comment on attachment 9012322 [details]
Bug 1493968 - Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke

Daisuke Akatsuka (:daisuke) has approved the revision.

Attachment #9012322 - Flags: review+

Pulsebot

Comment 6

•

6 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b8b09f59546
Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke

Eliza Balazs [:ebalazs_]

Comment 7

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/0b8b09f59546

Status: ASSIGNED → RESOLVED

Closed: 6 years ago

status-firefox64: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 64

Noemi Erli[:noemi_erli]

Updated

•

6 years ago

Status: RESOLVED → REOPENED

status-firefox64: fixed → ---

Resolution: FIXED → ---

Noemi Erli[:noemi_erli]

Comment 8

•

6 years ago

Reopening since this issue started again:
https://treeherder.mozilla.org/logviewer.html#?job_id=202282364&repo=mozilla-inbound&lineNumber=1920

[task 2018-09-28T19:28:47.785Z] 19:28:47     INFO - TEST-UNEXPECTED-FAIL | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_navigate.js | A promise chain failed to handle a rejection: Connection closed, pending error from root, type listTabs failed - stack: _queueResponse/responsePromise<@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1192:15
[task 2018-09-28T19:28:47.786Z] 19:28:47     INFO - promise callback*_queueResponse@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1190:8
[task 2018-09-28T19:28:47.787Z] 19:28:47     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1329:7
[task 2018-09-28T19:28:47.788Z] 19:28:47     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
[task 2018-09-28T19:28:47.790Z] 19:28:47     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
[task 2018-09-28T19:28:47.791Z] 19:28:47     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
[task 2018-09-28T19:28:47.792Z] 19:28:47     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
[task 2018-09-28T19:28:47.793Z] 19:28:47     INFO - _sendRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:747:7
[task 2018-09-28T19:28:47.794Z] 19:28:47     INFO - _attemptNextRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:782:5
[task 2018-09-28T19:28:47.795Z] 19:28:47     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:870:5
[task 2018-09-28T19:28:47.796Z] 19:28:47     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
[task 2018-09-28T19:28:47.797Z] 19:28:47     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
[task 2018-09-28T19:28:47.798Z] 19:28:47     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
[task 2018-09-28T19:28:47.799Z] 19:28:47     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
[task 2018-09-28T19:28:47.800Z] 19:28:47     INFO - _queueResponse/responsePromise<@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1189:7
[task 2018-09-28T19:28:47.801Z] 19:28:47     INFO - promise callback*_queueResponse@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1181:8
[task 2018-09-28T19:28:47.802Z] 19:28:47     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1329:7
[task 2018-09-28T19:28:47.803Z] 19:28:47     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
[task 2018-09-28T19:28:47.805Z] 19:28:47     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
[task 2018-09-28T19:28:47.806Z] 19:28:47     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
[task 2018-09-28T19:28:47.807Z] 19:28:47     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
[task 2018-09-28T19:28:47.809Z] 19:28:47     INFO - _sendRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:747:7
[task 2018-09-28T19:28:47.811Z] 19:28:47     INFO - _attemptNextRequest@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:782:5
[task 2018-09-28T19:28:47.812Z] 19:28:47     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/shared/client/debugger-client.js:870:5
[task 2018-09-28T19:28:47.813Z] 19:28:47     INFO - send/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:64:11
[task 2018-09-28T19:28:47.815Z] 19:28:47     INFO - exports.makeInfallible/<@resource://devtools/shared/base-loader.js -> resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:14
[task 2018-09-28T19:28:47.817Z] 19:28:47     INFO - DevToolsUtils.executeSoon*exports.executeSoon@resource://devtools/shared/base-loader.js -> resource://devtools/shared/DevToolsUtils.js:57:21
[task 2018-09-28T19:28:47.818Z] 19:28:47     INFO - send@resource://devtools/shared/base-loader.js -> resource://devtools/shared/transport/local-transport.js:58:7
[task 2018-09-28T19:28:47.819Z] 19:28:47     INFO - _queueResponse/responsePromise<@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1189:7
[task 2018-09-28T19:28:47.820Z] 19:28:47     INFO - promise callback*_queueResponse@resource://devtools/shared/base-loader.js -> resource://devtools/server/main.js:1181:8
[task 2018-09-28T19:28:47.821Z] 19:28:47     INFO - onPacket@resource://devtools/shared/base-loader.js -> resource://devtools/server

Marco Mucci [:MarcoM]

Updated

•

6 years ago

Status: REOPENED → ASSIGNED

Comment hidden (Intermittent Failures Robot)

23 failures in 2773 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 5
* mozilla-inbound: 8
* mozilla-central: 10

Platform breakdown:
* windows10-64-nightly: 1
* windows7-32-nightly: 1
* windows7-32-msvc: 1
* windows7-32: 5
* windows10-64-msvc: 2
* osx-10-10: 3
* linux64: 3
* windows10-64: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-09-24&endday=2018-09-30&tree=all

Julian Descottes [:jdescottes]

Assignee

Comment 10

•

6 years ago

The failure rate still decreased significantly, we will look at this when we have more time.

Status: ASSIGNED → NEW

Priority: P1 → P3

Julian Descottes [:jdescottes]

Assignee

Updated

•

6 years ago

Assignee: jdescottes → nobody

Comment hidden (Intermittent Failures Robot)

3 failures in 2708 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 2
* try: 1

Platform breakdown:
* linux64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-10-01&endday=2018-10-07&tree=all

Julian Descottes [:jdescottes]

Assignee

Updated

•

6 years ago

Blocks: remote-debugging-ng
No longer blocks: remote-debugging-ng-m1

Comment hidden (Intermittent Failures Robot)

11 failures in 2740 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 5
* mozilla-inbound: 3
* mozilla-central: 3

Platform breakdown:
* linux64: 3
* linux64-ccov: 1
* windows10-64: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-10-08&endday=2018-10-14&tree=all

Julian Descottes [:jdescottes]

Assignee

Updated

•

6 years ago

No longer blocks: remote-debugging-ng

Comment hidden (Intermittent Failures Robot)

5 failures in 2759 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 4
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 1
* linux64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-10-15&endday=2018-10-21&tree=all

Comment hidden (Intermittent Failures Robot)

10 failures in 2584 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 3
* mozilla-inbound: 3
* mozilla-central: 4

Platform breakdown:
* windows10-64: 3
* osx-10-10: 3
* linux64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-10-22&endday=2018-10-28&tree=all

Comment hidden (Intermittent Failures Robot)

3 failures in 2978 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 1
* autoland: 2

Platform breakdown:
* windows10-64: 2
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-10-29&endday=2018-11-04&tree=all

Comment hidden (Intermittent Failures Robot)

2 failures in 3007 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 2

Platform breakdown:
* linux64: 1
* windows10-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-11-05&endday=2018-11-11&tree=all

Comment hidden (Intermittent Failures Robot)

18 failures in 563 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 3
* mozilla-inbound: 4
* mozilla-central: 3
* autoland: 8

Platform breakdown:
* linux64-devedition: 1
* osx-10-10: 1
* windows10-64: 6
* windows10-64-ccov: 1
* linux64: 7
* windows10-64-nightly: 1
* linux32-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-11-15&endday=2018-11-15&tree=all

Comment hidden (Intermittent Failures Robot)

35 failures in 2917 pushes (0.012 failures/push) were associated with this bug in the last 7 days.

This is the #39 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 4
* autoland: 15
* mozilla-central: 6
* try: 10

Platform breakdown:
* linux64-nightly: 1
* windows10-64-devedition: 1
* linux32-nightly: 1
* linux64: 13
* windows10-64-ccov: 1
* osx-10-10: 1
* windows10-64: 11
* linux32-devedition: 1
* macosx64-nightly: 1
* linux64-devedition: 3
* windows10-64-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-11-12&endday=2018-11-18&tree=all

Julian Descottes [:jdescottes]

Assignee

Comment 19

•

6 years ago

Attached file Bug 1493968 - Wait for requests to finish in aboutdebugging navigate test;r=ladybenko — Details

Still not sure what is the root issue here, but none of the regular connect tests are failing so I think the issue occurs when we remove tabs in the second step.

Julian Descottes [:jdescottes]

Assignee

Updated

•

6 years ago

Assignee: nobody → jdescottes

Status: NEW → ASSIGNED

Marco Mucci [:MarcoM]

Updated

•

6 years ago

Blocks: remote-debugging-ng-m2

Priority: P3 → P1

Julian Descottes [:jdescottes]

Assignee

Comment 20

•

6 years ago

Looks like this fixes the issue: https://treeherder.mozilla.org/#/jobs?repo=try&revision=54fb26f29f84eb8313feb74b2479011fc4da9f79

Julian Descottes [:jdescottes]

Assignee

Comment 21

•

6 years ago

After I said that my try run had a few failures on OSX debug jobs apparently. 

So after investigating a bit more, it really seems we can't fully control how many tabs/workers/extensions updates we will receive.

During the first part of the test, where we load about:debugging and add a background tab, we receive:
- 3 REQUEST_TABS_SUCCESS
- 2 REQUEST_WORKERS_SUCCESS
- 1 REQUEST_EXTENSION_SUCCESS

I still think the "settle" approach would work better for us here. 

New approach: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c6cdac65cdd63b3d42e625c2e24d72d6942dcf1

Pulsebot

Comment 22

•

6 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e71f2bd051cf
Wait for requests to finish in aboutdebugging navigate test;r=ladybenko

Stefan Hindli [:stefan_hindli]

Comment 23

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/e71f2bd051cf

Status: ASSIGNED → RESOLVED

Closed: 6 years ago → 6 years ago

status-firefox65: --- → fixed

Resolution: --- → FIXED

Comment hidden (Intermittent Failures Robot)

4 failures in 2387 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1
* try: 3

Platform breakdown:
* linux64-nightly: 1
* linux64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-11-19&endday=2018-11-25&tree=all

Ryan VanderMeulen [:RyanVM]

Updated

•

6 years ago

status-firefox64: --- → affected

Target Milestone: Firefox 64 → Firefox 65

Ryan VanderMeulen [:RyanVM]

Updated

•

6 years ago

status-firefox64: affected → wontfix

Comment hidden (Intermittent Failures Robot)

1 failures in 2648 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-release: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1493968&startday=2018-12-17&endday=2018-12-23&tree=all

Razvan Maries

Updated

•

5 years ago

Updated

•

5 years ago

Bug 1493968 - Wait for initial targets in aboutdebugging navigate test to avoid race condition;r=daisuke 6 years ago Julian Descottes [:jdescottes] 46 bytes, text/x-phabricator-request	daisuke : review+	Details \| Review
Bug 1493968 - Wait for requests to finish in aboutdebugging navigate test;r=ladybenko 6 years ago Julian Descottes [:jdescottes] 47 bytes, text/x-phabricator-request		Details \| Review