1495238 - (SQLIte3.25.3) Upgrade to SQLite 3.25.3

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[NVD]

https://www.sqlite.org/news.html

https://www.sqlite.org/releaselog/3_25_2.html

"SQLite version 3.25.2 is another patch against 3.25.0 that fixes still more problems associated with the new window function feature and the ALTER TABLE enhancements. Of particular note is the new PRAGMA legacy_alter_table=ON command, which causes the ALTER TABLE RENAME command to behave in the same goofy way that it did before the enhancements found in version 3.25.0 → references to renamed tables that are inside the bodies of triggers and views are not updated. The legacy behavior is arguably a bug, but some programs depend on the older buggy behavior. The 3.25.2 release also contains a fix to window function processing for VIEWs. There also a slew of other minor fixes that affect obscure compile-time options. See the Fossil Timeline for details."

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Marco, any urgency for this on your end?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

FWIW, there's already been a few more commits to upstream branch-3.25, so I wouldn't be shocked if there's going to be a 3.25.3 release coming in the near-ish future.

Comment 3

[Marco Bonardo [:mak]]

No urgency, we don't use the new features yet. And I agree with comment 2 that looks like there will be another dot version, let's wait a bit for now.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

2018-11-05 - Release 3.25.3
SQLite version 3.25.3 is a third patch against 3.25.0 that fixes various problems that have come to light and which seem serious enough to justify a patch.

Want to take it, Marco?

Comment 5

[Marco Bonardo [:mak]]

yep, this one's good, even if they are very unlikely to affect us. Though someone may start using window functions.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I'm thinking I'll try to uplift this to Beta as well. Though maybe without the version bump in old-configure.in?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1495238 - Upgrade to SQLite 3.25.3. r=mak

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ac8b35289ed
Upgrade to SQLite 3.25.3. r=mak

Comment 9

[Marco Bonardo [:mak]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> I'm thinking I'll try to uplift this to Beta as well. Though maybe without
> the version bump in old-configure.in?

I don't think it's necessary, the fixes are unlikely to affect us, as I said. Just good to have for fixes to new features.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

OK, fine by me.

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3ac8b35289ed