1495622 - migrate wizardpage to CE

Status: RESOLVED FIXED

(Core :: XUL, task, P3)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

based on bug 1495357

Comment 2

[:Paolo Amadini]

Comment on attachment 9013491 [details] [diff] [review]
patch

Review of attachment 9013491 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/widgets/wizard.js
@@ +26,5 @@
> +    this.parentNode._accessMethod = "random";
> +    return val;
> +  }
> +}
> +customElements.define("wizardpage", MozWizardHeader);

This should be MozWizardPage. Did this patch pass manual or automated testing?

If none of the properties are actually used anywhere, or can be replaced by direct calls, we might as well remove the binding without making it a Custom Element.

This should also be based on mozilla-central, without the other patches for wizard conversions, like the MozWizardButtons that I see this is based on.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

this one is rebased relative trunk

Comment 4

[:Paolo Amadini]

Comment on attachment 9014256 [details] [diff] [review]
patch

Looks good to me.

Comment 5

[Brian Grinstead [:bgrins]]

Let's hold off on landing this until we figure out what's going on with Bug 1495946, since it's related to wizard/wizardpage.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62fac4388d24
Conver wizardpage binding to Custom Elements, r=paolo

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/62fac4388d24

Comment 8

[Dave Townsend [:mossop]]

This seems to have caused bug 1533396

Comment 10

[Anca Soncutean, Desktop QA]

Could this change affect other dialogs besides Profile manager? Should we test anything in particular to make sure nothing else was damaged?

Comment 11

[alexander :surkov (:asurkov)]

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #10)

Could this change affect other dialogs besides Profile manager? Should we test anything in particular to make sure nothing else was damaged?

I'm aware of two wizards in Firefox: ProfileManager and Import Wizard (Library -> Import Data ...). It's worth to check the second one for sure.

Dave, are there any other wizards?

Comment 12

[Dave Townsend [:mossop]]

There is this: https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/content/updates.xul

Apparently it is only ever used if you're extremely out of date or we fail to elevate on OSX. If you need to trigger this then mhowell might be able to help.