Status

()

P3
normal
5 months ago
5 months ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 months ago
Created attachment 9013491 [details] [diff] [review]
patch

based on bug 1495357
Attachment #9013491 - Flags: review?(paolo.mozmail)
(Assignee)

Updated

5 months ago
Priority: -- → P3

Comment 2

5 months ago
Comment on attachment 9013491 [details] [diff] [review]
patch

Review of attachment 9013491 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/widgets/wizard.js
@@ +26,5 @@
> +    this.parentNode._accessMethod = "random";
> +    return val;
> +  }
> +}
> +customElements.define("wizardpage", MozWizardHeader);

This should be MozWizardPage. Did this patch pass manual or automated testing?

If none of the properties are actually used anywhere, or can be replaced by direct calls, we might as well remove the binding without making it a Custom Element.

This should also be based on mozilla-central, without the other patches for wizard conversions, like the MozWizardButtons that I see this is based on.
Attachment #9013491 - Flags: review?(paolo.mozmail)
Blocks: 1495621
(Assignee)

Comment 3

5 months ago
Created attachment 9014256 [details] [diff] [review]
patch

this one is rebased relative trunk
Attachment #9013491 - Attachment is obsolete: true
Attachment #9014256 - Flags: review?(paolo.mozmail)

Comment 4

5 months ago
Comment on attachment 9014256 [details] [diff] [review]
patch

Looks good to me.
Attachment #9014256 - Flags: review?(paolo.mozmail) → review+
Let's hold off on landing this until we figure out what's going on with Bug 1495946, since it's related to wizard/wizardpage.
Depends on: 1495946
You need to log in before you can comment on or make changes to this bug.