1495898 - JavaScript error: resource://gre/modules/ActorManagerChild.jsm, line 72: NS_ERROR_FILE_NOT_FOUND:

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1485649 +++

https://taskcluster-artifacts.net/AGyzGCxlT_uSUSpm3G4j0g/0/public/logs/live_backing.log

shows this error
JavaScript error: resource://gre/modules/ActorManagerChild.jsm, line 72: NS_ERROR_FILE_NOT_FOUND:

542 times.

Interested, Magnus?

Comment 1

[alta88]

This is because the modules provided by toolkit are not packaged.

@RESPATH@/actors/*

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1495898-actors.patch

OK, let's see what that does. Thanks Alta88!

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9020084 [details] [diff] [review]
1495898-actors.patch

I guess that's broken on the beta, too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3a32487f3a23
add @RESPATH@/actors/* to package manifest (analysis by Alta88). rs=bustage-fix

Comment 5

[doug2]

Yes,  Broken in 63.0b1

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks. I'll check the fix on trunk and then it goes to TB 64 beta.

Comment 7

[Jorg K (CEST = GMT+2)]

Total success, error gone - \o/

Comment 8

[Jorg K (CEST = GMT+2)]

Beta (TB 64):
https://hg.mozilla.org/releases/comm-beta/rev/3f4c3e99a115e23e787377bc44ea248bda0731c9

Comment 9

[alta88]

Weren't there a lot of webextension tests that were turned off?  They should be turned on if we're going to be serious about implementing it properly..

Comment 10

[Jorg K (CEST = GMT+2)]

They've all been turned on again here: https://hg.mozilla.org/mozilla-central/rev/163742dd3235

Comment 12

[alta88]

Test management has been really excellent, I just want to point out that web extension tests also need to be reviewed and some that seem to potentially apply to Tb have been turned off:

+skip-if = appname == "thunderbird" || os == "android"
 [test_ext_cookieBehaviors.js]
..
+fail-if = appname == "thunderbird"
 skip-if = os == "android"
 [test_ext_downloads_misc.js]
..
+fail-if = appname == "thunderbird"
 [test_ext_extension.js]
..
+skip-if = appname == "thunderbird"
 [test_ext_onmessage_removelistener.js]
..
+skip-if = appname == "thunderbird"
 [test_ext_webRequest_startup.js]
..
+skip-if = appname == "thunderbird"
 [test_ext_xhr_capabilities.js]

Some Fx web extensions should Just Work in Tb at this point. For example, script injection doesn't seem to work and it may be because the messageManager object attached to messagepane <browser> doesn't have a processMessageManager handler, from what I've debugged so far in uBlock, which finally semi works for http urls given this patch.

(I know it's separate bugs, I'm just sayin..)

Comment 13

[Jorg K (CEST = GMT+2)]

(In reply to alta88 from comment #12)
> (I know it's separate bugs, I'm just sayin..)
Thanks for you help in this bug, especially since it also fixed an urgent print preview problem (see bug 1502219).

I'd appreciate it very much if you could file a new bug for the WE stuff and CC me and [e-mail].