Closed Bug 1496401 Opened Last year Closed Last year

Update Debugger Frontend v93

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

Assignee: nobody → jlaster
No longer depends on: 1494464, 1495547, 1495727
Attached patch 93-1.patchSplinter Review
Attachment #9014378 - Flags: review?(dwalsh)
Attachment #9014378 - Flags: review?(dwalsh) → review+
Backed out changeset 8566206da1bf (bug 1496401) for devtools failures at test/mochitest/browser_jsterm_await.js

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/922b85723d9f859be0e37f8454e1e76e8e8e9af9

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&selectedJob=203461893&revision=8566206da1bf661588bd69be4b951eb8a94c2e92

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=203425206&repo=mozilla-inbound&lineNumber=3480

Log snippet: [task 2018-10-04T15:58:10.611Z] 15:58:10     INFO - TEST-START | devtools/client/webconsole/test/mochitest/browser_jsterm_await.js
[task 2018-10-04T15:58:11.282Z] 15:58:11     INFO - GECKO(3320) | console.warn: "Error when calling getMappedExpression" (new ReferenceError("window is not defined", "resource://devtools/shared/base-loader.js -> resource://devtools/client/debugger/new/dist/vendors.js", 5555))
[task 2018-10-04T15:58:55.617Z] 15:58:55     INFO - TEST-INFO | started process screentopng
[task 2018-10-04T15:58:56.132Z] 15:58:56     INFO - TEST-INFO | screentopng: exit 0
[task 2018-10-04T15:58:56.133Z] 15:58:56     INFO - Buffered messages logged at 15:58:10
[task 2018-10-04T15:58:56.134Z] 15:58:56     INFO - Entering test bound 
[task 2018-10-04T15:58:56.135Z] 15:58:56     INFO - Adding a new tab with URL: data:text/html;charset=utf-8,Web Console test top-level await
[task 2018-10-04T15:58:56.136Z] 15:58:56     INFO - Tab added and finished loading
[task 2018-10-04T15:58:56.136Z] 15:58:56     INFO - Opening the toolbox
[task 2018-10-04T15:58:56.138Z] 15:58:56     INFO - Buffered messages logged at 15:58:11
[task 2018-10-04T15:58:56.138Z] 15:58:56     INFO - Toolbox opened and focused
[task 2018-10-04T15:58:56.140Z] 15:58:56     INFO - Evaluate a top-level await expression
[task 2018-10-04T15:58:56.140Z] 15:58:56     INFO - Buffered messages finished
[task 2018-10-04T15:58:56.141Z] 15:58:56     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/mochitest/browser_jsterm_await.js | Test timed out - 
[task 2018-10-04T15:58:56.147Z] 15:58:56     INFO - Removing tab.
Flags: needinfo?(jlaster)
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c16194093413
Revert "Backed out changeset 8566206da1bf for devtools failures at test/mochitest/browser_jsterm_await.js"
This release has fixed regressions against pause from v91:
== Change summary for alert #16471 (as of Thu, 04 Oct 2018 13:21:18 GMT) ==

Regressions:

  2%  damp complicated.inspector.close.DAMP windows10-64 opt e10s stylo     55.92 -> 57.14

Improvements:

 12%  damp inspector.layout.open linux64 opt e10s stylo                500.98 -> 440.60
 12%  damp custom.jsdebugger.pause.DAMP linux64 pgo e10s stylo         440.57 -> 387.63
 11%  damp custom.jsdebugger.pause.DAMP linux64 opt e10s stylo         503.85 -> 450.74
  9%  damp custom.jsdebugger.pause.DAMP windows7-32 opt e10s stylo     551.71 -> 500.05
  7%  damp complicated.inspector.open.DAMP linux64 opt e10s stylo      575.33 -> 532.46

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=16471
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Blocks: 1503278
No longer blocks: 1503278
Flags: needinfo?(jlaster)
Depends on: 1520136
You need to log in before you can comment on or make changes to this bug.