1501379 - Update Debugger Frontend v95

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[David Walsh :davidwalsh]

https://github.com/devtools-html/debugger.html/compare/release-94...release-95

Comment 1

[David Walsh :davidwalsh]

Attachment: 1501379-1.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7c19ce06974f9e6e3d39527a0fdaaf78cc6bce3

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 9019447 [details] [diff] [review]
1501379-1.patch

Review of attachment 9019447 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch David. We are missing the README update and there is one issue to fix in browser.ini. 
Regarding the localization note inconsistency, up to you to fix it or not.

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +655,4 @@
>  [browser_dbg-asm.js]
>  [browser_dbg-async-stepping.js]
>  [browser_dbg-sourcemapped-breakpoint-console.js]
> +[browser_dbg-xhr-breakpoints.js]

The skip-if applies to the test above. Technically, the [test-name.js] creates a section, and everything until the next section applies to it (helps remembering it for me).

So here this moves the skip-if from browser_dbg-sourcemapped-breakpoint-console.js to your new browser_dbg-xhr-breakpoints.js and this is probably not what was intended.

::: devtools/client/locales/en-US/debugger.properties
@@ +518,5 @@
> +xhrBreakpoints.header=XHR Breakpoints
> +xhrBreakpoints.placeholder=Break when URL contains
> +xhrBreakpoints.label=Add XHR breakpoint
> +
> +# LOCALIZATION NOTE (pauseOnAnyXHR): The pause on any xhr checkbox description

A review comment from flod was not applied:

Case in the note should be consistent xhr -> XHR
https://github.com/devtools-html/debugger.html/pull/6934#discussion_r224149355

Comment 3

[David Walsh :davidwalsh]

Attachment: 1501379-2.patch

Thank you Julian!  Updated all items!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7340e821bf23c277a27d767e1ceb6e72f4ef137

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 9019524 [details] [diff] [review]
1501379-2.patch

Review of attachment 9019524 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks David, it looks good. Just the link to update in the README.

::: devtools/client/debugger/new/README.mozilla
@@ +5,2 @@
>  
>  Comparison: https://github.com/devtools-html/debugger.html/compare/release-93...release-94

We should update the link

Comment 5

[David Walsh :davidwalsh]

Attachment: 1501379-3.patch

*facepalms* Updated!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b48368889eb5
Update debugger frontend v95. r=jdescottes

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b48368889eb5