Closed Bug 1501379 Opened 3 years ago Closed 3 years ago

Update Debugger Frontend v95


(DevTools :: Debugger, enhancement, P3)



(firefox65 fixed)

Firefox 65
Tracking Status
firefox65 --- fixed


(Reporter: davidwalsh, Assigned: davidwalsh)




(1 file, 2 obsolete files)

Keywords: checkin-needed
Comment on attachment 9019447 [details] [diff] [review]

Review of attachment 9019447 [details] [diff] [review]:

Thanks for the patch David. We are missing the README update and there is one issue to fix in browser.ini. 
Regarding the localization note inconsistency, up to you to fix it or not.

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +655,4 @@
>  [browser_dbg-asm.js]
>  [browser_dbg-async-stepping.js]
>  [browser_dbg-sourcemapped-breakpoint-console.js]
> +[browser_dbg-xhr-breakpoints.js]

The skip-if applies to the test above. Technically, the [test-name.js] creates a section, and everything until the next section applies to it (helps remembering it for me).

So here this moves the skip-if from browser_dbg-sourcemapped-breakpoint-console.js to your new browser_dbg-xhr-breakpoints.js and this is probably not what was intended.

::: devtools/client/locales/en-US/
@@ +518,5 @@
> +xhrBreakpoints.header=XHR Breakpoints
> +xhrBreakpoints.placeholder=Break when URL contains
> +xhrBreakpoints.label=Add XHR breakpoint
> +
> +# LOCALIZATION NOTE (pauseOnAnyXHR): The pause on any xhr checkbox description

A review comment from flod was not applied:

Case in the note should be consistent xhr -> XHR
Attachment #9019447 - Flags: review?(jdescottes)
Attached patch 1501379-2.patch (obsolete) — Splinter Review
Thank you Julian!  Updated all items!
Attachment #9019447 - Attachment is obsolete: true
Attachment #9019524 - Flags: review?(jdescottes)
Comment on attachment 9019524 [details] [diff] [review]

Review of attachment 9019524 [details] [diff] [review]:

Thanks David, it looks good. Just the link to update in the README.

::: devtools/client/debugger/new/README.mozilla
@@ +5,2 @@
>  Comparison:

We should update the link
Attachment #9019524 - Flags: review?(jdescottes) → review+
Attached patch 1501379-3.patchSplinter Review
*facepalms* Updated!
Attachment #9019524 - Attachment is obsolete: true
Attachment #9019660 - Flags: review+
Keywords: checkin-needed
Pushed by
Update debugger frontend v95. r=jdescottes
Keywords: checkin-needed
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Depends on: 1502224
Depends on: 1502256
Depends on: 1502494
Depends on: 1503278
No longer depends on: 1503278
You need to log in before you can comment on or make changes to this bug.