Closed Bug 1496879 Opened 6 years ago Closed 4 years ago

Re-implement bug list navigation with local storage

Categories

(bugzilla.mozilla.org :: Search, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: kohei, Assigned: kohei)

References

(Blocks 10 open bugs)

Details

Attachments

(1 file)

The current implementation of the bug list navigation, that allows moving back and forth between the results while on show_bug.cgi, relies on a cookie called BUGLIST. I *think* it has to be re-implemented using the local storage before removing the server push stuff from buglist.cgi,
No longer blocks: 1478011
Blocks: 1529362
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED

So this is a prerequisite of the new bug list rendered client-side. While storing users’ recent searches server-side could improve UX, the current implementation seems a legacy tech — the Web Storage API was not widely available 10 years ago and cookie storage is limited. I have reproduced the same functionality now with localStorage. Will send a PR later today.

This reimplementation also solves these issues:

  • buglist.cgi is no longer redirected to clean the URL, so the results page will be displayed faster. The search params will be added to the URL client-side using history.replaceState().
  • The navigation now reflects the order of sorted bug lists
  • The navigation now works properly when multiple bug lists are opened in browser tabs
  • The navigation is now displayed for logged-out users
  • The URL of buglist.cgi will be updated when you sort the list (Bug 756172)
  • The user-specific list_id param will be removed from buglist.cgi
  • The Last search results link now runs the search again instead of showing the last retrieved bugs. This allows to always go back to the bug list, edit the search criteria, follow the feed, or share the URL (Bug 118805, Bug 325123, Bug 336007, Bug 568936, Bug 590751, Bug 734094, Bug 1314777, Bug 1401806)
  • The First/Last links will be disabled properly just like Prev/Next when you’re on the first/last bug on the list or when First/Last is the same as Prev/Next
  • These navigation links will have a tooltip showing the bug’s ID, status, resolution and summary
  • The Last search results link will also have a tooltip showing the search title if specified (e.g. Saved Searches)
  • You can now navigate bugs with keyboard shortcuts: [ for Prev, ] for Next
  • The UI has been simplified
Attached file GitHub Pull Request
Blocks: 336007
Blocks: 1314777
See Also: → 990721
Blocks: 1401806
Blocks: 734094
Blocks: 118805
Blocks: 254569
Blocks: 364059
No longer blocks: 756172
Blocks: 1330451
No longer blocks: 1330451

I’m rather thinking about building a single-page app.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: