1497002 - When customizing browser, going from 'Normal' or 'Touch' to 'Compact' causes close window text ('x') to go under button.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Greg Mierzwinski [:sparky]]

Attachment: Screenshot of the bug in top-right corner

I've attached a screenshot showing (in the top right corner) how the minimize, full size, and close text for the buttons goes down under the actual buttons.

I can always reproduce this by doing the following:
1. Go to 'Customize...'
2. Disable the title bar.
3. Start on 'Normal' or 'Touch' mode at the bottom of the screen, in the 'Density' drop-down menu.
4. Change to 'Compact' mode and watch the text for the buttons move away.

I found that it's also possible for this to happen when going from 'Compact' to 'Normal' mode, though it doesn't always happen.

This is happening on a machine running Ubuntu 18.04.

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Screenshot in normal mode (without the bug)

What it looks like on 'Normal' density mode when the bug is not present.

Comment 2

[Greg Mierzwinski [:sparky]]

Furthermore, when this bug occurs and I hover over the tabs and address bar area, the text for those buttons (-, square, X) will move themselves to the correct area.

Comment 3

[:Gijs (he/him)]

Linux titlebar decoration issues -> off to Core:: Widget: GTK. :stransky, are you the right person to ask about these? If not could you please forward the ni? Thank you!

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Sure. Greg, do you have dragspace enabled? Is that fixed when main window is resized? If so it's a dupe of Bug 1447775.

Comment 5

[Greg Mierzwinski [:sparky]]

Drag space is not enabled, and playing with it's setting does not fix the bug or affect it in any way. And this bug only happens when the main window is at full-size, I haven't been able to reproduce it at smaller sizes. Plus, anytime I move the cursor towards the 'x' button, the text repositions itself over top of the button (or it fixes itself). 

I don't think that this is the same bug because I haven't seen the actual button move down vertically. I've been able to reproduce that bug you mention though by starting with a small main window with drag space enabled, and then maximizing the window, making the buttons move (down) away from the vertical center. Once drag space is disabled, the buttons return to their correct positions.

I did some testing and found that the Ubuntu 18.04 display settings need to be set to 200% scale (default), at 100% there's no bug - unless Firefox was opened before changing the display settings, then the bug will persist.

Comment 6

[Greg Mierzwinski [:sparky]]

The bug I'm seeing is similar to this one which is marked as a duplicate of Bug 1447775: Bug 1460958

But in my case, resizing has no effect on the bug, only mouse hovering. It's fine if you mark this as a duplicate, I'll test with the patch that will be made for that bug on this one.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1497002 - [Linux/CSD] Position headerbar button icons according to the actual button, r=jhorak

Comment 8

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb1565f1a2167d2f35b52fd811f9433d39a3b7b2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a22edb5c335
[Linux/CSD] Position headerbar button icons according to the actual button, r=jhorak

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9a22edb5c335