1519606 - Close button decoration is off center when using Ubuntu Yaru theme

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Asif Youssuff]

Attachment: non centered active window close decoration

Using Ubuntu Disco with the Yaru theme.

Bug 1497002 regressed the display of the red-orange decoration around active window close button so that it is now not centered.

11:24.82 INFO: No more inbound revisions, bisection finished.
11:24.82 INFO: Last good revision: ebee32dc7abedd8621353f4ee27af9cf077e427e
11:24.82 INFO: First bad revision: 9a22edb5c335044baf5fd63f28553d5f6cfb4103
11:24.82 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ebee32dc7abedd8621353f4ee27af9cf077e427e&tochange=9a22edb5c335044baf5fd63f28553d5f6cfb4103

See screenshot.

Comment 1

[Kestrel]

Attachment: misaligned-buttons.png

The maximize/restore button is also affected. The minimize button is unaffected.

Ambiance theme is unaffected.

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking for 66 as this is affecting our primary UI on Ubuntu (Yaru is the default theme on Ubuntu) and we are getting close to beta.

Comment 4

[mthw0]

Yaru theme is not the only one affected, also NewAdwaita, Qohir and others.

Comment 5

[Daniel Holbert [:dholbert]]

(tagging as regression from bug 1490344, since that's where the default behavior changed such that this is now an issue in the default configuration)

Also, as a local workaround (not a fix): users can right-click the toolbar & choose "customize", and then check the "Title Bar" checkbox in the bottom left corner.

Comment 7

[Cameron McCormack (:heycam)]

Martin, are you able to take a look at this?

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Yes, it's on my todo list for this week.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1519606 - [Linux/Gtk] Don't add margin to icon position at titlebar buttons as it's already applied at drawing, r=dao

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1519606 - [Linux/Gtk] Compute correct margin for left titlebar buttons placement, r=dao

Depends on D17347

Comment 12

[Cosmin Sabou [:CosminS]]

The second patch is not yet r+ by dao, please add the checkin-needed tag after that. Thank you.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4f53e83954a
[Linux/Gtk] Don't add margin to icon position at titlebar buttons as it's already applied at drawing, r=dao
https://hg.mozilla.org/integration/autoland/rev/5797d4eee0ea
[Linux/Gtk] Compute correct margin for left titlebar buttons placement, r=dao

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/f4f53e83954a
https://hg.mozilla.org/mozilla-central/rev/5797d4eee0ea