1497066 - Firefox CSD buttons blurry with HiDpi when using Arc and Ubuntu Ambiance GTK themes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[ilia]

Attachment: Screenshot from 2018-10-07 17-10-07.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

1. Run any new linux distro with GNOME
2. Set 200% scaling in display settings
3. use Arc GTK theme
4. disable firefox titlebar in customize

More info here: https://github.com/NicoHood/arc-theme/issues/138

note: Ubuntu Ambiance has this issue too


Actual results:

Firefox is not rendering the image from background-image property of the window controls with 200% scaling.


Expected results:

The window controls should be rendered at high resolution and not be blurry

Comment 1

[ilia]

Still the case on nightly 65.0a1

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Can you please try Wayland builds? Run GDK_BACKEND=wayland ./firefox on Wayland enabled system. X11 has trouble to support 200% scale when running on semi-HiDPI systems.

Comment 3

[ilia]

So sorry I didn't see this earlier.

I am not sure what you mean by waylan builds, but nightly has it right? I updated today.

Test: latest firefox-trunk, logged in to a gnome wayland session. Ran with command GDK_BACKEND=wayland firefox-trunk

Still got the blurry buttons still, and loads of weird window resizing issues. I could send a screenshot if it is useful but I assume it is not as nothing has changed since the last time.

Also what do you mean by semi-HiDpi?

Comment 4

[ilia]

Tell me to stop if should stop saying this over and over, but it's still been a problem on latest nightlies.

I tried wayland launching again, they were still blurry.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to ilia from comment #3)

So sorry I didn't see this earlier.

I am not sure what you mean by waylan builds, but nightly has it right? I
updated today.

Test: latest firefox-trunk, logged in to a gnome wayland session. Ran with
command GDK_BACKEND=wayland firefox-trunk

Still got the blurry buttons still, and loads of weird window resizing
issues. I could send a screenshot if it is useful but I assume it is not as
nothing has changed since the last time.

A dupe of Bug 1419467?

Also what do you mean by semi-HiDpi?

When your monitor doesn't have high density DPI (I think it's DPI > 196 or so) you don't get HiDPI by default in X11 and you can't set it by the scale factor in X11. The HiDPI/Scale factor works in Wayland only in that case.

Comment 6

[ilia]

A dupe of Bug 1419467?

Ah it seems you are right about that! Should this be closed?

When your monitor doesn't have high density DPI (I think it's DPI > 196 or so) you don't get HiDPI by default in X11 and you can't set it by the scale factor in X11. The HiDPI/Scale factor works in Wayland only in that case.

Ah :/

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Let's do the work at Bug 1319838.

Comment 8

[Vlad Zahorodnii [:zzag]]

(In reply to Martin Stránský [:stransky] from comment #5)

When your monitor doesn't have high density DPI (I think it's DPI > 196 or so)
196 or 192?

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to Vlad Zagorodniy from comment #8)

(In reply to Martin Stránský [:stransky] from comment #5)

When your monitor doesn't have high density DPI (I think it's DPI > 196 or so)
196 or 192?

I guess 192 as it's 2x96 and 96 is a standard desktop DPI.

Comment 10

[Vlad Zahorodnii [:zzag]]

Attachment: Bug 1497066 - [Linux/HiDPI] Draw header bar buttons at correct scale on HiDPI, r=stransky

We need to call gtk_style_context_set_scale() before rendering a header
bar button in order to make sure that -gtk-scaled() selects the right
asset on HiDPI.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0be50b85894
[Linux/HiDPI] Draw header bar buttons at correct scale on HiDPI, r=stransky

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c0be50b85894