1497602 - Enable DirectX screen capturer on Windows

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Dan Minor [:dminor]]

We've disabled the DirectX screen capturer here [1]. We should enable and test it.

[1] https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/media/webrtc/trunk/webrtc/modules/desktop_capture/screen_capturer_win.cc#26

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1497602 - Enable DirectX screen capturer on Windows; r=pehrsons!

This enables support for the DirectX screen capturer. We use the default
DesktopCaptureOptions which do not set the option to use the DirectX screen
capturer so this change will have no effect with the current code.

For what it's worth, I tested enabling the DirectX option and it worked fine on my
system, but I don't see any reason to not follow the defaults provided by
webrtc.org in this case.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb07312cfbe8
Enable DirectX screen capturer on Windows; r=pehrsons

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/eb07312cfbe8