Closed Bug 1497610 Opened Last year Closed Last year

Upstream IsNewerOrSameTimestamp

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

63 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Upstream just uses IsNewerTimestamp. We should research why we made this change, and if it is still relevant, attempt to upstream it.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
So this was from bug 985254, which made the H264 packetization code work reasonably correctly.  There's no way a Try run would catch any issues with that code.

This was so that it wouldn't barf if we passed single SPS or PPS NALs in with the same timestamp as a later Iframe NAL -- in RTP, multiple NALs with the same timestamp are ok, it's only wrong if the timestamp goes backwards.  So while much of the code we landed in bug 985254 may not be relevant (or if relevant may require recoding), this is likely still correct, even if it currently avoids tripping on this problem due to other processing in the reception of H264 and de-jittering.
You can see an earlier attempt to upstream this code, linked to by that bug
Similar to Bug 1497974, these are only used in VCMJitterBuffer, which the older jitter buffer that we no longer use. We're safe to remove these.
The affected functions are only used by VCMJitterBuffer, which is the older
jitter buffer that is no longer in use. We can safely remove these
modifications.
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ed0ed11b23d
Remove IsNewerOrSameTimestamp; r=bwc
https://hg.mozilla.org/mozilla-central/rev/5ed0ed11b23d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.