1497610 - Upstream IsNewerOrSameTimestamp

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Dan Minor [:dminor]]

Upstream just uses IsNewerTimestamp. We should research why we made this change, and if it is still relevant, attempt to upstream it.

Comment 1

[Dan Minor [:dminor]]

Try run for the removal here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6e1b30de38612a5d44e70daae8a769a3247a481

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

So this was from bug 985254, which made the H264 packetization code work reasonably correctly.  There's no way a Try run would catch any issues with that code.

This was so that it wouldn't barf if we passed single SPS or PPS NALs in with the same timestamp as a later Iframe NAL -- in RTP, multiple NALs with the same timestamp are ok, it's only wrong if the timestamp goes backwards.  So while much of the code we landed in bug 985254 may not be relevant (or if relevant may require recoding), this is likely still correct, even if it currently avoids tripping on this problem due to other processing in the reception of H264 and de-jittering.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

You can see an earlier attempt to upstream this code, linked to by that bug

Comment 4

[Dan Minor [:dminor]]

Similar to Bug 1497974, these are only used in VCMJitterBuffer, which the older jitter buffer that we no longer use. We're safe to remove these.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1497610 - Remove IsNewerOrSameTimestamp; r=bwc!

The affected functions are only used by VCMJitterBuffer, which is the older
jitter buffer that is no longer in use. We can safely remove these
modifications.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ed0ed11b23d
Remove IsNewerOrSameTimestamp; r=bwc

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5ed0ed11b23d