1498216 - Have custom scrollbars blend with underlying natively for macOS

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

+++ This bug was initially created as a clone of Bug #1494607 +++

Like what we do for GTK widget. That should match authors' expectation better.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1498216 - Properly support alpha channel on custom scrollbars. r=spohl

This also includes implementation of nsNativeThemeCocoa::GetWidgetAutoColor
which should have been done in bug 1464722 actually.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ae5ba83fa1c3a378ea1336b3359635dc72e7461

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

[Tracking Requested - why for this release]: I'd hope this change to be shipped with scrollbar-color.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Stephen, could you have a look at the patch?

Comment 5

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Yes, I've been working through my backlog of reviews and this one is next on the list. Sorry about the delay.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0087557ee59e
Properly support alpha channel on custom scrollbars. r=spohl

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/0087557ee59e

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 9016860 [details]
Bug 1498216 - Properly support alpha channel on custom scrollbars. r=spohl

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1492012

User impact if declined: macOS would be the only platform has different behavior on semi-transparent custom scrollbar in the first release of scrollbar-color support, which would be unfortunate.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This change only touches code path used by the new feature, which isn't widely used yet, so it's unlikely to break any existing stuff.

String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9016860 [details]
Bug 1498216 - Properly support alpha channel on custom scrollbars. r=spohl

Ensures cross-platform consistency for a new feature shipping in Fx64. Approved for 64.0b4.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/92b434174fcf

Comment 11

[Bogdan Maris, Desktop Test Engineering]

Does this need manual qa? If yes can you please provide steps in order to activate this feature so I can see the fix on latest Beta and Nightly builds.

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

I don't think it does. Let's not bother it :) I'm reasonable confident it works as expected (otherwise ntim may have shouted at me).

Comment 13

[Bogdan Maris, Desktop Test Engineering]

(In reply to Xidorn Quan [:xidorn] UTC+11 from comment #12)
> I don't think it does. Let's not bother it :) I'm reasonable confident it
> works as expected (otherwise ntim may have shouted at me).

Thanks Xidorn, marking this bug accordingly.