1498594 - [de-xbl] Remove mail-emailheaderfield binding.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Arshad Khan [:arshad]]

https://searchfox.org/comm-central/source/mail/base/content/mailWidgets.xml#453

Comment 1

[Arshad Khan [:arshad]]

Attachment: mail-emailheaderfield.patch

Used the custom element approach, because the object approach will be unpleasant like we saw while converting statuspanel.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9016674 [details] [diff] [review]
mail-emailheaderfield.patch

Review of attachment 9016674 [details] [diff] [review]:
-----------------------------------------------------------------

Unless this is on top of another patch, the context menu  "Add To Address Book" is broken by this patch.
https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet.inc#1172

Comment 3

[Arshad Khan [:arshad]]

I ll try to first land the mail-emailaddress patch then work on this..

Comment 4

[Arshad Khan [:arshad]]

(In reply to Magnus Melin [:mkmelin] from comment #2)
> Comment on attachment 9016674 [details] [diff] [review]
> mail-emailheaderfield.patch
> 
> Review of attachment 9016674 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Unless this is on top of another patch, the context menu  "Add To Address
> Book" is broken by this patch.
> https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet.
> inc#1172

hey how do i test email-headerfield? It is only inside #expandedSenderrow which remains collapsed for all the emails that i have. how do i send an email to myself that have an sender field?

Comment 5

[Magnus Melin [:mkmelin]]

Easiest to just go into the profile and modify the mail file. (Details on irc.)

Comment 6

[Arshad Khan [:arshad]]

(In reply to Magnus Melin [:mkmelin] from comment #2)
> Comment on attachment 9016674 [details] [diff] [review]
> mail-emailheaderfield.patch
> 
> Review of attachment 9016674 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Unless this is on top of another patch, the context menu  "Add To Address
> Book" is broken by this patch.
> https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet.
> inc#1172

it is not due to this patch.. you can check it on default branch, same issue is still there. I ll try to fix this in this patch. LOoks like the newItemAdded evvent is not fired when address is added. https://searchfox.org/comm-central/source/mail/base/content/msgHdrView.js#1568 this line is executed even for sender's emailaddress but the newItemAdded event is never fired.

Comment 7

[Arshad Khan [:arshad]]

Attachment: mail-emailheaderfield.patch

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9021744 [details] [diff] [review]
mail-emailheaderfield.patch

Review of attachment 9021744 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah this works, although it's a bit heavy weight as a CE as it does very little. But we can fix that later after the multi email case is also done. r=mkmelin

Comment 9

[Arshad Khan [:arshad]]

Need to rebase first..

Comment 10

[Magnus Melin [:mkmelin]]

Applied cleanly to a new checkout for me

Comment 11

[Arshad Khan [:arshad]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1d64c981ae414742c23f2e6ada428c2cb66d1650

Comment 12

[Arshad Khan [:arshad]]

linux - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f5b181cd08d42c0c036b0e2fc16e85838ff5e962

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cffa7cb63305
Remove mail-emailheaderfield binding. r=mkmelin

Comment 14

[Jorg K (CEST = GMT+2)]

The friendly sheriff rebased this after bug 1502988 :-)