Closed Bug 1498594 Opened Last year Closed Last year

[de-xbl] Remove mail-emailheaderfield binding.

Categories

(Thunderbird :: Mail Window Front End, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: arshad, Assigned: arshad)

References

Details

Attachments

(1 file, 1 obsolete file)

Assignee: nobody → arshdkhn1
Blocks: 1498596
Attached patch mail-emailheaderfield.patch (obsolete) — Splinter Review
Used the custom element approach, because the object approach will be unpleasant like we saw while converting statuspanel.
Attachment #9016674 - Flags: review?(mkmelin+mozilla)
Blocks: tb-war-on-xbl
No longer blocks: 1498596
Comment on attachment 9016674 [details] [diff] [review]
mail-emailheaderfield.patch

Review of attachment 9016674 [details] [diff] [review]:
-----------------------------------------------------------------

Unless this is on top of another patch, the context menu  "Add To Address Book" is broken by this patch.
https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet.inc#1172
Attachment #9016674 - Flags: review?(mkmelin+mozilla)
I ll try to first land the mail-emailaddress patch then work on this..
Depends on: 1491698
(In reply to Magnus Melin [:mkmelin] from comment #2)
> Comment on attachment 9016674 [details] [diff] [review]
> mail-emailheaderfield.patch
> 
> Review of attachment 9016674 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Unless this is on top of another patch, the context menu  "Add To Address
> Book" is broken by this patch.
> https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet.
> inc#1172

hey how do i test email-headerfield? It is only inside #expandedSenderrow which remains collapsed for all the emails that i have. how do i send an email to myself that have an sender field?
Flags: needinfo?(mkmelin+mozilla)
Easiest to just go into the profile and modify the mail file. (Details on irc.)
Flags: needinfo?(mkmelin+mozilla)
(In reply to Magnus Melin [:mkmelin] from comment #2)
> Comment on attachment 9016674 [details] [diff] [review]
> mail-emailheaderfield.patch
> 
> Review of attachment 9016674 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Unless this is on top of another patch, the context menu  "Add To Address
> Book" is broken by this patch.
> https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet.
> inc#1172

it is not due to this patch.. you can check it on default branch, same issue is still there. I ll try to fix this in this patch. LOoks like the newItemAdded evvent is not fired when address is added. https://searchfox.org/comm-central/source/mail/base/content/msgHdrView.js#1568 this line is executed even for sender's emailaddress but the newItemAdded event is never fired.
Attachment #9016674 - Attachment is obsolete: true
Attachment #9021744 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9021744 [details] [diff] [review]
mail-emailheaderfield.patch

Review of attachment 9021744 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah this works, although it's a bit heavy weight as a CE as it does very little. But we can fix that later after the multi email case is also done. r=mkmelin
Attachment #9021744 - Flags: review?(mkmelin+mozilla) → review+
Status: NEW → ASSIGNED
Need to rebase first..
Keywords: checkin-needed
Applied cleanly to a new checkout for me
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cffa7cb63305
Remove mail-emailheaderfield binding. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
The friendly sheriff rebased this after bug 1502988 :-)
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.