Reimplementing treecol-image after treecol is converted into custom element.

RESOLVED FIXED in Thunderbird 65.0

Status

defect
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: arshad, Assigned: arshad)

Tracking

(Blocks 1 bug)

Trunk
Thunderbird 65.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Assignee: nobody → arshdkhn1
Status: NEW → ASSIGNED
Blocks: 1502990
Blocks: tb-war-on-xbl
No longer blocks: 1502990
Depends on: 1499423
Posted patch treecolimage_WIP.patch (obsolete) — Splinter Review
Comment on attachment 9021141 [details] [diff] [review]
treecolimage_WIP.patch

Review of attachment 9021141 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWidgets.js
@@ +153,5 @@
>      return this.getAttribute("label");
>    }
>  }
>  
> +class MozTreecolImage extends MozTreecolBase {

I don't expect MozTreecolBase or MozTreecol will be directly accessible on the window, but I think you'll be able to do `customElement.get("treecol")` to get a reference to the class. See https://bugzilla.mozilla.org/show_bug.cgi?id=1499423#c25
(In reply to Brian Grinstead [:bgrins] from comment #2)
> Comment on attachment 9021141 [details] [diff] [review]
> treecolimage_WIP.patch
> 
> Review of attachment 9021141 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/base/content/mailWidgets.js
> @@ +153,5 @@
> >      return this.getAttribute("label");
> >    }
> >  }
> >  
> > +class MozTreecolImage extends MozTreecolBase {
> 
> I don't expect MozTreecolBase or MozTreecol will be directly accessible on
> the window, but I think you'll be able to do `customElement.get("treecol")`
> to get a reference to the class. See
> https://bugzilla.mozilla.org/show_bug.cgi?id=1499423#c25

thanks for letting me know again.
This has become urgent since we have 217 test failures over in bug 1504076.
Comment on attachment 9021141 [details] [diff] [review]
treecolimage_WIP.patch

I tried this patch.

First it doesn't apply on tip.

The treecol-image have no <image class="treecol-icon"> as child and so no icon is shown.
Attachment #9021141 - Flags: feedback-
(In reply to Richard Marti (:Paenglab) from comment #5)
> Comment on attachment 9021141 [details] [diff] [review]
> treecolimage_WIP.patch
> 
> I tried this patch.
> 
> First it doesn't apply on tip.
> 
> The treecol-image have no <image class="treecol-icon"> as child and so no
> icon is shown.

just about to post a new patch.. my build is goin on.
Attachment #9021141 - Attachment is obsolete: true
Attachment #9022096 - Flags: review?(mkmelin+mozilla)
the 30 errors in console are not due to this patch.. I ll look into that in a new bug if required.
Attachment #9022096 - Flags: feedback?(richard.marti)
Comment on attachment 9022096 [details] [diff] [review]
treecolimage.patch

Review of attachment 9022096 [details] [diff] [review]:
-----------------------------------------------------------------

I'll make these changes and land it. r=mkmelin

::: mail/base/content/SearchDialog.xul
@@ +128,5 @@
>                context="mailContext"
>                onkeydown="ThreadPaneKeyDown(event);"
>                onselect="ThreadPaneSelectionChanged();">
>            <treecols id="threadCols" pickertooltiptext="&columnChooser2.tooltip;">
> +            <treecol is="treecol-image" id="threadCol" persist="hidden ordinal" fixed="true" cycler="true"

would prefer id first for these

::: mail/base/content/mailWidgets.js
@@ +272,5 @@
> +    }
> +
> +    const src = this.getAttribute("src");
> +
> +    if (src != null) {

and remove attr for when it's null
Attachment #9022096 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9022096 [details] [diff] [review]
treecolimage.patch

Tested on Linux and Windows. The treecol-icons are where they should be.
Attachment #9022096 - Flags: feedback?(richard.marti) → feedback+
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8b5b4aa26193
Adding treecol-image custom element; r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.