1499026 - Update our in-tree ICU to 63

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Description

[André Bargull [:anba]]

Announcement for release candidate: https://sourceforge.net/p/icu/mailman/message/36430860/

List of fixed bugs: https://unicode-org.atlassian.net/issues/?jql=project%20%3D%20ICU%20AND%20status%20%3D%20Done%20AND%20resolution%20in%20(Fixed%2C%20%22Fixed%20by%20Other%20Ticket%22)%20AND%20fixVersion%20%3D%2063.1%20ORDER%20BY%20component%20ASC%2C%20created%20DESC

Comment 1

[André Bargull [:anba]]

Try build <https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d660424db2511122ea21ba09cb4dc37ff79345c> uncovered some issues, filed:
- https://unicode-org.atlassian.net/browse/ICU-20208
- https://unicode-org.atlassian.net/browse/ICU-20209

Comment 2

[André Bargull [:anba]]

Attachment: bug1499028-part1-icu-patches.patch

- Removes "bug-1466471-case-conversion-bugfix.diff" because the patch is no longer needed in ICU 63 (the underlying bug was fixed).
- Adds "bug-1499026-rename-checkImpl.diff" to avoid renaming "checkImpl" everywhere (conflicts with our |JSContext::checkImpl| and it's actually not necessary to version-rename "checkImpl" in ICU).
- Adds "bug-1499026-atomic-explicit-instantiation-msvc.diff" to fix compilation errors with clang-cl (|explicit instantiation of 'atomic' not in a namespace enclosing 'std'|)
  - It's possible we could avoid closing and opening the ICU namespaces when we instead use "-fms-compatibility", but it's seems better not to enable the MSVC bug compatibility mode for clang-cl.
  - MinGW reports |incomplete type 'icu_63::number::impl::NumberRangeFormatterImpl' where a complete type is required| [1], so I've also disabled the explicit instantiation of |std::atomic<icu::number::impl::NumberRangeFormatterImpl*>| when U_PLATFORM is U_PF_MINGW.
  - The explicit instantiation is necessary for non-MinGW Windows builds [2].


[1] https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=205765063&revision=535b6c45d71e79998a05f109765b749799fe5750
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=368f31de534bda5785ccc06f7b707b9b617b7529&selectedJob=205805302

Comment 3

[André Bargull [:anba]]

Attachment: bug1499028-part2-icu63.patch

The actual update to ICU 63.

Comment 4

[André Bargull [:anba]]

Attachment: bug1499028-part3-clobber.patch

Mandatory clobber.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 9017689 [details] [diff] [review]
bug1499028-part2-icu63.patch

Review of attachment 9017689 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 6

[André Bargull [:anba]]

Status update: I'm currently waiting for <https://github.com/unicode-org/icu/pull/251> to be merged, so we don't need custom ICU branches on top of the ICU 63 release.

Comment 7

[André Bargull [:anba]]

Attachment: bug1499028-part1-icu-patches.patch

Update part 1 to exclude the new custom patches for ICU 63, instead we'll use the ICU 63 maintenance branch which already includes the necessary ICU changes.

Comment 8

[André Bargull [:anba]]

Attachment: bug1499028-part2-icu63.patch

Update to ICU 63 (maintenance branch), carrying r+.

Comment 9

[André Bargull [:anba]]

Attachment: bug1499028-part3-clobber.patch

Comment 10

[André Bargull [:anba]]

Diff between ICU 63 release and maintenance branch: https://github.com/unicode-org/icu/compare/release-63-1...maint/maint-63

Comment 11

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=31fe7bc2f7e566dd755efe92fd1c031dc9bb00e4

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6412ed4d933f
Part 1: Update patches for ICU 63. r=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/9deb23f8b29b
Part 2: Update in-tree ICU to release 63.1. rs=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/b31fa37d257e
Part 3: Updating ICU requires a clobber. r=clobber

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6412ed4d933f
https://hg.mozilla.org/mozilla-central/rev/9deb23f8b29b
https://hg.mozilla.org/mozilla-central/rev/b31fa37d257e