Update our in-tree ICU to 63

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
8 months ago
6 months ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 wontfix, firefox65 fixed)

Details

Attachments

(3 attachments, 3 obsolete attachments)

Assignee

Updated

8 months ago
Blocks: 1473588
Assignee

Comment 2

8 months ago
- Removes "bug-1466471-case-conversion-bugfix.diff" because the patch is no longer needed in ICU 63 (the underlying bug was fixed).
- Adds "bug-1499026-rename-checkImpl.diff" to avoid renaming "checkImpl" everywhere (conflicts with our |JSContext::checkImpl| and it's actually not necessary to version-rename "checkImpl" in ICU).
- Adds "bug-1499026-atomic-explicit-instantiation-msvc.diff" to fix compilation errors with clang-cl (|explicit instantiation of 'atomic' not in a namespace enclosing 'std'|)
  - It's possible we could avoid closing and opening the ICU namespaces when we instead use "-fms-compatibility", but it's seems better not to enable the MSVC bug compatibility mode for clang-cl.
  - MinGW reports |incomplete type 'icu_63::number::impl::NumberRangeFormatterImpl' where a complete type is required| [1], so I've also disabled the explicit instantiation of |std::atomic<icu::number::impl::NumberRangeFormatterImpl*>| when U_PLATFORM is U_PF_MINGW.
  - The explicit instantiation is necessary for non-MinGW Windows builds [2].


[1] https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=205765063&revision=535b6c45d71e79998a05f109765b749799fe5750
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=368f31de534bda5785ccc06f7b707b9b617b7529&selectedJob=205805302
Attachment #9017688 - Flags: review?(jwalden+bmo)
Assignee

Comment 3

8 months ago
Posted patch bug1499028-part2-icu63.patch (obsolete) — Splinter Review
The actual update to ICU 63.
Attachment #9017689 - Flags: review?(jwalden+bmo)
Assignee

Comment 4

8 months ago
Mandatory clobber.
Attachment #9017690 - Flags: review+

Updated

8 months ago
Attachment #9017688 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 9017689 [details] [diff] [review]
bug1499028-part2-icu63.patch

Review of attachment 9017689 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #9017689 - Flags: review?(jwalden+bmo) → review+
Assignee

Updated

8 months ago
Blocks: 1501721
Assignee

Comment 6

8 months ago
Status update: I'm currently waiting for <https://github.com/unicode-org/icu/pull/251> to be merged, so we don't need custom ICU branches on top of the ICU 63 release.
Assignee

Comment 7

8 months ago
Update part 1 to exclude the new custom patches for ICU 63, instead we'll use the ICU 63 maintenance branch which already includes the necessary ICU changes.
Attachment #9017688 - Attachment is obsolete: true
Attachment #9021854 - Flags: review+
Assignee

Comment 8

8 months ago
Update to ICU 63 (maintenance branch), carrying r+.
Attachment #9017689 - Attachment is obsolete: true
Attachment #9021855 - Flags: review+
Assignee

Comment 9

8 months ago
Attachment #9017690 - Attachment is obsolete: true
Attachment #9021856 - Flags: review+
Assignee

Comment 10

8 months ago
Diff between ICU 63 release and maintenance branch: https://github.com/unicode-org/icu/compare/release-63-1...maint/maint-63

Comment 12

8 months ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6412ed4d933f
Part 1: Update patches for ICU 63. r=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/9deb23f8b29b
Part 2: Update in-tree ICU to release 63.1. rs=Waldo
https://hg.mozilla.org/integration/mozilla-inbound/rev/b31fa37d257e
Part 3: Updating ICU requires a clobber. r=clobber
Keywords: checkin-needed

Comment 13

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6412ed4d933f
https://hg.mozilla.org/mozilla-central/rev/9deb23f8b29b
https://hg.mozilla.org/mozilla-central/rev/b31fa37d257e
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee

Updated

6 months ago
Depends on: 1513934
You need to log in before you can comment on or make changes to this bug.