Closed Bug 1499026 Opened 5 years ago Closed 5 years ago

Update our in-tree ICU to 63


(Core :: JavaScript: Internationalization API, enhancement)

Not set



Tracking Status
firefox64 --- wontfix
firefox65 --- fixed


(Reporter: anba, Assigned: anba)




(3 files, 3 obsolete files)

Blocks: 1473588
- Removes "bug-1466471-case-conversion-bugfix.diff" because the patch is no longer needed in ICU 63 (the underlying bug was fixed).
- Adds "bug-1499026-rename-checkImpl.diff" to avoid renaming "checkImpl" everywhere (conflicts with our |JSContext::checkImpl| and it's actually not necessary to version-rename "checkImpl" in ICU).
- Adds "bug-1499026-atomic-explicit-instantiation-msvc.diff" to fix compilation errors with clang-cl (|explicit instantiation of 'atomic' not in a namespace enclosing 'std'|)
  - It's possible we could avoid closing and opening the ICU namespaces when we instead use "-fms-compatibility", but it's seems better not to enable the MSVC bug compatibility mode for clang-cl.
  - MinGW reports |incomplete type 'icu_63::number::impl::NumberRangeFormatterImpl' where a complete type is required| [1], so I've also disabled the explicit instantiation of |std::atomic<icu::number::impl::NumberRangeFormatterImpl*>| when U_PLATFORM is U_PF_MINGW.
  - The explicit instantiation is necessary for non-MinGW Windows builds [2].

Attachment #9017688 - Flags: review?(jwalden+bmo)
Attached patch bug1499028-part2-icu63.patch (obsolete) — Splinter Review
The actual update to ICU 63.
Attachment #9017689 - Flags: review?(jwalden+bmo)
Attached patch bug1499028-part3-clobber.patch (obsolete) — Splinter Review
Mandatory clobber.
Attachment #9017690 - Flags: review+
Attachment #9017688 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 9017689 [details] [diff] [review]

Review of attachment 9017689 [details] [diff] [review]:

Attachment #9017689 - Flags: review?(jwalden+bmo) → review+
Blocks: 1501721
Status update: I'm currently waiting for <> to be merged, so we don't need custom ICU branches on top of the ICU 63 release.
Update part 1 to exclude the new custom patches for ICU 63, instead we'll use the ICU 63 maintenance branch which already includes the necessary ICU changes.
Attachment #9017688 - Attachment is obsolete: true
Attachment #9021854 - Flags: review+
Update to ICU 63 (maintenance branch), carrying r+.
Attachment #9017689 - Attachment is obsolete: true
Attachment #9021855 - Flags: review+
Attachment #9017690 - Attachment is obsolete: true
Attachment #9021856 - Flags: review+
Diff between ICU 63 release and maintenance branch:
Pushed by
Part 1: Update patches for ICU 63. r=Waldo
Part 2: Update in-tree ICU to release 63.1. rs=Waldo
Part 3: Updating ICU requires a clobber. r=clobber
Keywords: checkin-needed
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Depends on: 1504122
Depends on: 1513934
You need to log in before you can comment on or make changes to this bug.