1499055 - [META] Support docker-worker tasks in generic-worker

Status: REOPENED

(Taskcluster :: Workers, enhancement)

Description

[Pete Moore [:pmoore][:pete]]

In order to be able to discontinue support for docker-worker, we will need to migrate all docker-worker tasks to generic-worker.

Generic worker should support the same format task payloads as docker worker, so that the migration can be as seamless as possible.

Comment 1

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for generic-worker

This PR is not ready for merging, it is a starting point for adding docker support. It runs tasks inside a docker container, but does not allow the task to specify an image, it uses a hardcoded image to run the task inside. It doesn't cache docker images or provide support for building docker images.

It provides go types generated from the docker-worker payload schema, in order to interpret docker-worker style payloads.

When generic-worker reads a task payload, it should evaluate if it is a native generic-worker task payload, or a docker-worker task payload. If it is a docker-worker task payload, the worker should load the payload into the docker-worker go types, then transform that data into the native generic-worker payload go types. This should localise most of the changes to the codebase to this transformation step, so that the existing mechanics of interpreting the task payloads can be left untouched.

Additionally we should add support to the generic-worker task payload format for the additional docker-worker features, so that at some point, we could more easily drop support for legacy docker-worker style payloads, to keep things simpler/cleaner. Of course this is not mandatory, but may be desirable in the interests of simplicity.

Comment 2

[Pete Moore [:pmoore][:pete]]

Splitting this bug up into separate bugs for the constituent parts...

Comment 3

[Pete Moore [:pmoore][:pete]]

Not actively working on this at the moment.

Comment 4

[Pete Moore [:pmoore][:pete]]

Reopening inactive bugs, because they may still need attention. Historically, inactive bugs were closed, but this hides the fact there are genuine issues which have not been resolved.