1499163 - Scrolling regression on Fennec Nightly has been really choppy for the past 3 days

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andrei Petcu]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Open a tab with a large page like https://en.m.wikipedia.org/wiki/World_War_II
Try to scroll down.


Actual results:

Scrolling is really really slow. Please see the video https://vimeo.com/user43268556/review/295233814/27261ebd5f


Expected results:

It should have scrolled fast. In the video Beta scrolls fast.

Comment 1

[Andrei Petcu]

Fixed the links https://vimeo.com/295233814

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

What device is this?

Comment 3

[Andrei Petcu]

OnePLus2, LineageOS 14.1 (based on Android 7.1.2)

Comment 4

[Bogdan Surd, QA [:bsurd, NI]]

Hello and thank you for your report,

Tried to reproduce this on a OnePlus 2 running OxygenOS 3.6.0, 3.6.1 being the latest for OnePlus 2 devices,  seeing as LineageOS does not come by default with the device you should file a bug with the OS developers as FF works perfectly fine with official builds of Android.

@Kevin do you have any extra input here?

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Botond landed some changes that are nightly only. He should have a look at this bug.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

andreip, if this is easy to reproduce, can you get a regression window? A few different changes landed recently and it would help to identify which one caused this.

Comment 7

[Andrei Petcu]

How can I get a regression window? Are any docs on this?

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

Use mozregression, assuming Linux from comment 0.

* Set your phone to accept USB debugging connections via Android's "Developer options" in the settings
* download and install the android platform tools for your operating system https://developer.android.com/studio/releases/platform-tools or use your distro provided source for Android developer's "adb"
* confirm that "adb devices" returns your phone's information See https://wiki.archlinux.org/index.php/Android_Debug_Bridge for useful debugging info if it does not work. Common issues is not adding the udev rules or accepting the user prompt on the phone.

Once you have the phone connected via adb then install mozregression 

* pip install mozregression (in venv or virtualenv if you want)
* mozregression -n fennec -g 2018-09-15

* answer good or bad for the build
* the next build to test will be downloaded automatically
* once the bisection is done you should be down to a single checkin paste the last 5 or so lines of the bisection that shows the regressing bug. 

If you run into issues email me directly at my user name at mozilla com

Comment 9

[Botond Ballo [:botond]]

It seems unlikely that this is related to bug 1457586. Bug 1457586 affects flings only, that is, the behaviour after the user's finger leaves the screen.

In the video from comment 1, you can't see the user's finger, but the scrolling is choppy right from the start of the scroll, when presumably the user's finger is still in contact with the screen.

Comment 10

[Andrei Petcu]

I ran it twice with these params "mozregression -n fennec -g 2018-09-10". This is what I got on both runs:

21:37.76 INFO: Last good revision: 7a2f29bbe2a8b484893efffb8f032b53f1794766
21:37.76 INFO: First bad revision: d41905041ca7f615f90fce70e1de3c325e490c44
21:37.76 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7a2f29bbe2a8b484893efffb8f032b53f1794766&tochange=d41905041ca7f615f90fce70e1de3c325e490c44

Comment 11

[Andrei Petcu]

Damn... mozregression pretty much nuked my Firefox Nightly profile which I use as my daily driver. Any chance I can get it back somehow?

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Thanks for finding the regression range! But sadly, no, mozregression overwrites the Nightly install and the way Android apps works, that means the profile is gone. If you have Firefox Sync enabled on that profile you can recover whatever was synced.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Eitan, regression range points to you, can you take a look?

Comment 14

[Eitan Isaacson [:eeejay]]

Andre,

It seems like you may have an accessibility service running, do you know which one? You can see that in settings->accessibility.

The current state in nightly is not optimized, so there can definitely be slowdowns with some services, it would be helpful to know which ones cause this.

Comment 15

[Andrei Petcu]

I'm using Keepass2Android which seems to need a11y. https://play.google.com/store/apps/details?id=keepass2android.keepass2android&hl=en

I disabled it and Firefox scrolls really fast.

I disabled this feature, still seems to work following my workflow (I'm still on an old Android version and I use Keepass2Android as a separate keyboard app when I want to enter users/passwords)

Is there a bug following a11y optimizations? I might need to enable it in the future and I want to track the progress of this feature.

Comment 16

[David Durst [:ddurst]]

Does this still affect 64?

Comment 17

[Eitan Isaacson [:eeejay]]

Looks like this specific service traverses the entire document tree on each accessible scroll event (this happens every 100ms while scrolling).

I'm going to introduce some caching for this kind of use case soon, and I hope we can back port it to 64.


https://github.com/PhilippC/kp2a_accservice_autofill/blob/master/Kp2aAccServiceLib/app/src/main/java/keepass2android/autofill/AutoFillService.java#L204

Comment 18

[Chris Lord [:cwiiis]]

Just to add that I've been seeing this on a stock OnePlus3, and to work around, setting layout.frame-rate (or something like that) to 60, basically fixes the smoothness, but doesn't fix that the scrolling is really tricky (frequently takes off in the wrong direction or doesn't fling properly).

Comment 19

[Eitan Isaacson [:eeejay]]

Do you have an accessibility service enabled? That might be another issue.

Comment 20

[Andrei Petcu]

I also had the same issue: I scroll down but it goes up. It started to appear with the choppy scroll. It dissapeared after disabling a11y. It showed up in most of the bad commits marked in mozregression. I think it might be related to this.

Comment 21

[Kartikaya Gupta (email:[e-mail])]

That's bug 1499941

Comment 22

[Chris Lord [:cwiiis]]

(In reply to Eitan Isaacson [:eeejay] from comment #19)
> Do you have an accessibility service enabled? That might be another issue.

I do, for bitwarden password filling.

Comment 23

[Chris Peterson [:cpeterson]]

Eitan, I'm assigning this bug to you for now because this looks like a regression from bug 1479037.

Comment 24

[Eitan Isaacson [:eeejay]]

My plan is to remove all blocking and synchronous calls by implementing a couple of caching schemes. Once those land and are enabled, we'll check in on this bug to see if the experience has improved.

More in bug 1479039 and bug 1502187.

Comment 25

[Marion Daly [:mdaly]]

Status of this bug?

Comment 26

[Eitan Isaacson [:eeejay]]

Patches are up in bug 1479039, after that a followup to enable caching and this should be resolved.

Comment 27

[Liz Henry (:lizzard) (relman/hg->git project)]

We are getting some reports of scrolling issues on Fennec, and if this may be one cause we could consider uplift to 64 beta.

Comment 28

[Marion Daly [:mdaly]]

(In reply to Eitan Isaacson [:eeejay] from comment #26)
> Patches are up in bug 1479039, after that a followup to enable caching and
> this should be resolved.

Should we resolve this bug or we waiting for 1506709?

Comment 29

[Eitan Isaacson [:eeejay]]

Andrie,

Can you give this a try on a recent a nightly build? I think this issue should be resolved.

Comment 30

[Andrei Petcu]

it is fixed. I have both keepass and bitwarden accessibility enabled. no issues.

Comment 31

[Ryan VanderMeulen [:RyanVM]]

The relevant patches were uplifted to 64 last week, so calling this bug fixed for that release. We should get some QA testing to confirm, though.

Comment 32

[Bogdan Surd, QA [:bsurd, NI]]

@andreip could you help us by checking on Beta as well? Since we were not able to reproduce the issue on the devices we had on hand.

You can download the beta build from here: http://archive.mozilla.org/pub/mobile/candidates/64.0b13-candidates/build1/android-api-16/multi/
You need to download the .apk file.

Thanks in advance!

Comment 33

[Andrei Petcu]

The beta build works great on my phone! Thank you!

Comment 34

[Chris Peterson [:cpeterson]]

status-geckoview64=fixed

Comment 35

[Andrei Bodea[:andrei]]

Device:
 - Samsung Galaxy S9 (Android 8.0.0)

I couldn't reproduce this issue and based on Andreip Comment 33 I remove the qe-verify and I Verify this issue as fixed in the latest Beta build 64.0b15 build2(2018-12-03).