1479037 - Introduce full content accessible tree support in GeckoView

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Eitan Isaacson [:eeejay]]

This is for the likes of UIAutomator. Note, because of the synchronous nature of Android's a11y API, this will be synchronous and will block threads and e10s processes. This is a naive implementation that should probably not be used by end users and really just for testing.

Comment 2

[Eitan Isaacson [:eeejay]]

Since I can't figure out how to break this up into smaller bugs. Here is a patch set that provides a usable first pass at native accessibility.

"Usable" meaning that it may synchronously block threads and processes, it should still usable from a user's perspective. It also establishes a baseline for tests, so we can cache and optimize in the next few passes.

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1479037 - Assign a 32bit ID to each accessible, and make them retrievable from root 1/4. r?Jamie

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r?yzen,jchen

Disabled most jsunit tests temporarily in this patch. Will modify and bring them
back up in later patches, as stuff is reimplemented.

Disabled most jsat mochitests. Will have a followup for but reënabling or
porting, depending on the test.

Depends on D6681

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1479037 - Implement native accessible tree 3/4. r?jchen,jamie

Depends on D6682

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1479037 - Introduce native event support 4/4. r?jchen?jamie

Depends on D6683

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9011519 [details]
Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r?yzen,jchen

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 8

[James Teh [:Jamie]]

Comment on attachment 9011518 [details]
Bug 1479037 - Assign a 32bit ID to each accessible, and make them retrievable from root 1/4. r?Jamie

James Teh [:Jamie] has approved the revision.

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9011519 [details]
Bug 1479037 - Remove virtual content node, js autofill, and event support 2/4. r?yzen,jchen

Yura Zenevich [:yzen] has approved the revision.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8a20bd86895
Assign a 32bit ID to each accessible, and make them retrievable from root 1/4. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/c926c6470235
Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen
https://hg.mozilla.org/integration/autoland/rev/630601f0663e
Implement native accessible tree 3/4. r=jchen,yzen
https://hg.mozilla.org/integration/autoland/rev/85f8ca59f747
Introduce native event support 4/4. r=jchen,yzen?jamie

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f8a20bd86895
https://hg.mozilla.org/mozilla-central/rev/c926c6470235
https://hg.mozilla.org/mozilla-central/rev/630601f0663e
https://hg.mozilla.org/mozilla-central/rev/85f8ca59f747

Comment 12

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1479037) on dev's request for causing android crashes. a=backout


See Bug 1497883

Backout:
https://hg.mozilla.org/mozilla-central/rev/8dfeff72def34dea3ee1a59185a73d2840ae77f3

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f44f29dc7ae
Assign a 32bit ID to each accessible, and make them retrievable from root 1/4. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/dab75afa1e1e
Remove virtual content node, js autofill, and event support 2/4. r=jchen,yzen
https://hg.mozilla.org/integration/autoland/rev/97b5d09ed65a
Implement native accessible tree 3/4. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/d41905041ca7
Introduce native event support 4/4. r=jchen,yzen?jamie

Comment 14

[Eitan Isaacson [:eeejay]]

Relanded with a fix.

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7f44f29dc7ae
https://hg.mozilla.org/mozilla-central/rev/dab75afa1e1e
https://hg.mozilla.org/mozilla-central/rev/97b5d09ed65a
https://hg.mozilla.org/mozilla-central/rev/d41905041ca7