1499315 - Clicking on the magnifying-glass in the search bar to add new search engine does not work

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Peter Magyari (Desktop QA)]

[Affected versions]:
Firefox Nightly 64.0a1 (20181015223336)

[Affected platforms]:
-Windows 10(x64) 
-Windows 7(x64)
-Ubuntu 16.04
-Mac OS 10.14

[Steps to reproduce]:
1.Launch Firefox Nightly.
2.Enable the search bar from about:preferences#search by clicking on "Add search bar in toolbar" option.
3.Navigate to pages that contain different search engines and can be added to Firefox e.g. https://play.google.com/store, https://bugzilla.mozilla.org/ then select the magnifying glass from the Search Bar and add them to the search engines list.

[Expected result]:
The "Add <search engine>" button is displayed in the drop-down.
Clicking it adds the search engine to Firefox.

[Actual result]:
Clicking it does nothing.

Comment 1

[Peter Magyari (Desktop QA)]

Here is the regression range for this issue:

INFO: Last good revision: f574c731fcb0e65e969a53e86ffd7ff57bbe2000
INFO: First bad revision: eaa627409f750ad32fa96b757a0d35d7601b47c3

INFO: Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f574c731fcb0e65e969a53e86ffd7ff57bbe2000&tochange=eaa627409f750ad32fa96b757a0d35d7601b47c3

Comment 2

[Mike Kaply [:mkaply]]

No idea how we missed that. I'll take.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1499315 - Remove datatype for search bar addEngine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/135512b63ffc
Remove datatype for search bar addEngine. r=adw

Comment 5

[Diego Pino]

Thank you Mike for handling this.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/135512b63ffc

Comment 7

[Md. Majedul islam]

I have reproduced this bug with Nightly 64.0a1 (2018-10-15) on Windows 10, 64 bit!

The fix is now verified on Latest Nightly.

Build ID 	20181019100103
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Comment 8

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 64.0a1 (2018.10.16) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0a1 (2018.10.21) on Win 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13.
But using the link https://play.google.com/store the following download error is displayed: "Firefox could not download the search plugin from: https://play.google.com/opensearch.xml?hl=en_GB", see bug: 1381813.