Closed Bug 1499315 Opened Last year Closed Last year
Clicking on the magnifying-glass in the search bar to add new search engine does not work
46 bytes, text/x-phabricator-request
|Details | Review|
[Affected versions]: Firefox Nightly 64.0a1 (20181015223336) [Affected platforms]: -Windows 10(x64) -Windows 7(x64) -Ubuntu 16.04 -Mac OS 10.14 [Steps to reproduce]: 1.Launch Firefox Nightly. 2.Enable the search bar from about:preferences#search by clicking on "Add search bar in toolbar" option. 3.Navigate to pages that contain different search engines and can be added to Firefox e.g. https://play.google.com/store, https://bugzilla.mozilla.org/ then select the magnifying glass from the Search Bar and add them to the search engines list. [Expected result]: The "Add <search engine>" button is displayed in the drop-down. Clicking it adds the search engine to Firefox. [Actual result]: Clicking it does nothing.
Here is the regression range for this issue: INFO: Last good revision: f574c731fcb0e65e969a53e86ffd7ff57bbe2000 INFO: First bad revision: eaa627409f750ad32fa96b757a0d35d7601b47c3 INFO: Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f574c731fcb0e65e969a53e86ffd7ff57bbe2000&tochange=eaa627409f750ad32fa96b757a0d35d7601b47c3
No idea how we missed that. I'll take.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/135512b63ffc Remove datatype for search bar addEngine. r=adw
Thank you Mike for handling this.
I have reproduced this bug with Nightly 64.0a1 (2018-10-15) on Windows 10, 64 bit! The fix is now verified on Latest Nightly. Build ID 20181019100103 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
QA Whiteboard: [bugday-20181017]
I have reproduced this issue using Firefox 64.0a1 (2018.10.16) on Win 10 x64. I can confirm this issue is fixed, I verified using Firefox 64.0a1 (2018.10.21) on Win 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13. But using the link https://play.google.com/store the following download error is displayed: "Firefox could not download the search plugin from: https://play.google.com/opensearch.xml?hl=en_GB", see bug: 1381813.
You need to log in before you can comment on or make changes to this bug.