1499345 - Layout issues for “Extensions”, “Themes” and “Plugins”

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[CosminB]

Attachment: Bug1490366.png

[Affected versions]:
- Firefox 64.0a1 (20181015223336)

[Affected platforms]:
- Win 7 64-bit
- Mac OS X 10.13.3

[Steps to reproduce]:
1.Install some extensions & themes.
2.Open about:addons.
3.Observe “Extensions”,“Themes” and “Plugins”.

[Expected results]:
- There are no layout issues for “Extensions”, “Themes” and “Plugins” pages.

[Actual results]:
- The content of “Extensions”,“Themes” and “Plugins” is aligned to the left side and the right side of the page has a white space.

Please see the attached screenshot.

I did a regression window and the next pushlog is the one that I get it from the mozregression tool but I suspect that Bug 1490366 is the one that caused this regression.

Last good revision: aa4cdd603e44a5035074927038fa37bc44c68525
First bad revision: 8ad79784d883bbb2457ab066f4775ccb11377655
Pushlog: 
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8ad79784d883bbb2457ab066f4775ccb11377655&tochange =8ad79784d883bbb2457ab066f4775ccb11377655

Comment 1

[Mark Striemer [:mstriemer]]

The left alignment is intentional. It is more narrow now and left aligned to match about:preferences which is linked to in the sidebar.

Comment 2

[Mark Striemer [:mstriemer]]

As for the "Missing something?" info block, that will be centred and converted to photon styles in bug 1495708 which is currently in review.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

(In reply to Mark Striemer [:mstriemer] from comment #1)
> The left alignment is intentional. It is more narrow now and left aligned to
> match about:preferences which is linked to in the sidebar.

FIXED implies we landed a code change to make a bug go away. If it's intended behavior, INVALID seems like a more appropriate resolution.