Convert about:addons pages to the card styles

VERIFIED FIXED in Firefox 64

Status

()

enhancement
P2
normal
VERIFIED FIXED
10 months ago
6 months ago

People

(Reporter: mstriemer, Assigned: mstriemer)

Tracking

(Blocks 1 bug)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 verified, firefox65 verified)

Details

Attachments

(4 attachments)

There are shared card styles for the keyboard shortcuts now. They work fairly well on the listing pages and are a nice improvement.

Once bug 1303384 is landed, we should update the listing pages to match the same style.
I'm not seeing the pointer-events hack we talked about. Are you still going to implement that or did you find an alternative?
Flags: needinfo?(mstriemer)
I partially worked around it with CSS, it still isn't perfect, but good enough I think. The pointer-events hack didn't really work combined with the fix for the width of the richlistbox since you could only scroll while your mouse was over a richlistitem.
Flags: needinfo?(mstriemer)
Blocks: 1495713
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e0abd16a50b
Part 1: Move card styles to common from about:debugging r=dao
https://hg.mozilla.org/integration/autoland/rev/448672780572
Part 2: Convert about:addons to card UI r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/0b8bcd97f254
Part 3: Select the first item in richlistbox on focus r=dao
There was a bad rebase and a test change that should've been earlier in the series causing these failures. I'm running another try build now, but looks to be fixed and will re-land.
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a19f3794f0c9
Part 1: Move card styles to common from about:debugging r=dao
https://hg.mozilla.org/integration/autoland/rev/cb62a8b8a525
Part 2: Convert about:addons to card UI r=aswan,jaws
https://hg.mozilla.org/integration/autoland/rev/0a45a5634cf1
Part 3: Select the first item in richlistbox on focus r=dao
Depends on: 1499103
Depends on: 1499109
Hi, what is part 3 about?
Does it mean that there will always be at least one item selected?
I thought in a seltype="multiple" it is possible to have no selection and no currentIndex.
See https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/richlistbox .

There does not seem to be any explanation in this bug.
Thanks.
Flags: needinfo?(mstriemer)
Depends on: 1499294
Depends on: 1499345
The currentIndex path hasn't changed, so I'm thinking not having a currentIndex was not possible before. Without part 3 focusing the richlistbox wouldn't mark a child as selected but pressing DownArrow to move to the first item would move to the second since currentIndex was already 1.

If you don't think this is how it should work can you please file a new bug and explain why you think it should change?
Flags: needinfo?(mstriemer)
Summary: Convert about:addons listing pages to the card styles → Convert about:addons pages to the card styles
Duplicate of this bug: 1496070
Thanks, right. currentIndex was forced to other than -1 even before the patch, you just make the selection match the currentItem.
Depends on: 1500004
Depends on: 1500010
Depends on: 1500164
Depends on: 1500165
Depends on: 1500193
Depends on: 1500685
Posted image Bug1490366.gif
I was able to reproduce this issue on Firefox 62.0.3(20181001155545) under Win 7 64-bit and  Mac OS X 10.13.3.

This issue is verified as fixed on Firefox 65.0a1(20181022220734) and Firefox 64.0b3 (20181022150107) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached video.
Status: RESOLVED → VERIFIED
Depends on: 1516768
You need to log in before you can comment on or make changes to this bug.