Autofill search engine aliases in the address bar when '@' is typed as the first character

VERIFIED FIXED in Firefox 64

Status

()

defect
P2
normal
VERIFIED FIXED
7 months ago
7 months ago

People

(Reporter: adw, Assigned: adw)

Tracking

(Blocks 1 bug)

Trunk
Firefox 64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64+ verified)

Details

()

Attachments

(1 attachment)

Assignee

Description

7 months ago
+++ This bug was initially created as a clone of Bug #1496815 +++

For a visual explanation, please see the "autofill" part of Verdi's third bulleted mockup over at https://mozilla.invisionapp.com/share/4POCDI07U9A#/screens/322966230_Seach_Bar_Changes_For_63

This was originally part of bug 1496815, but the implementations of the popup portion and the autofill portion of that bullet point are different and separable enough that this deserves its own bug and patch I think.
Assignee

Comment 1

7 months ago
[Tracking Requested - why for this release]:

This is part of the work in the meta bug 1496772, and this was split off of bug 1496815, which is marked tracking 64.

(In reply to Mike de Boer [:mikedeboer] from bug 1496772 comment #0)
> [Tracking Requested - why for this release]:
> 
> There are a number of - should be - low effort changes to improve the search
> tiles/ keywords user interaction.
> We believe this will greatly impact the general usefulness, usability and
> users' perception of the feature when it launches in Firefox 63.
Assignee

Comment 2

7 months ago
One important unrelated change this makes is that previously (in my other patches), the only "@" aliases we recognized were the internal "@" aliases in nsSearchService.  While I was working on the new test here I realized that engines with user (or test) aliases that start with "@" aren't recognized as having "@" aliases, but why not IMO.

Comment 5

7 months ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/418fa1fa4f74
Autofill search engine aliases in the address bar when '@' is typed as the first character r=mak

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/418fa1fa4f74
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
This bug was covered by the over all testing efforts invested in the Search shortcuts in the awesomebar feature.
Marking this as verified fixed using Firefox 64.0b7 on the following OSes: Windows 7x86, Windows 10x64, Ubuntu 18.04 x64 and macOS 10.14.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.