Open Bug 1500000 Opened 3 years ago Updated 6 months ago
Client .release method
DebuggerClient host a "release" method that is only used by the WebConsoleActor: https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/devtools/shared/client/debugger-client.js#484-493 https://searchfox.org/mozilla-central/search?q=client.release(&case=false®exp=false&path= It seems to always be used to release a value grip actor. While switching all client to fronts, we will no longer manipulate actor IDs and instead always call requests through their front instance. Today this release method expects one argument, the actor ID to release. A first step in the process of refactoring WebConsoleClient to a front could be to expose a release method on the client and ensure that all the callsites switch from: DebuggerClient.release(actorID); to: WebConsoleClient.release(); It may not be so trivial as the callsites seem to currently pass around the actorID only and not necessarily the client.
(I'd be happy to move this bug to another bug entry if anyone wants to celebrate here ;))
with that bug id this bug looks so... intense.
Yeah, this report should be used for a party (not for work :-) @Alex: How much did you pay for the #? Honza
(In reply to Jan Honza Odvarko [:Honza] from comment #3) > @Alex: How much did you pay for the #? 11 years to create 991 bugs (https://bugzilla.mozilla.org/user_profile?user_id=283262)
(In reply to Alexandre Poirot [:ochameau] from comment #4) > (In reply to Jan Honza Odvarko [:Honza] from comment #3) > > @Alex: How much did you pay for the #? > > 11 years to create 991 bugs > (https://bugzilla.mozilla.org/user_profile?user_id=283262) You are awesome! Honza
Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve
Fission Milestone: --- → MVP
Fission Milestone: MVP → Future
Whiteboard: dt-fission-reserve → dt-fission-future
You need to log in before you can comment on or make changes to this bug.