1500165 - No gear menu in Recent Updates panel of new about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[YF (Yang)]

STR:
1. View Recent Updates in new about:addons.
2. Try to check for updates for add-ons.


Actual results:
No "check for updates" menu for now. I had to go to the other panel to use it and other menus of the gear menu and then return.


Expected results:
Allow to check for updates.

Comment 1

[Mark Striemer [:mstriemer]]

The gear was moved into the list view heading. Perhaps the list view heading should be part of the regular heading though.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1500165 - Include gear on each page of about:addons r?jaws

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: gear-everywhere.mov

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56f06760024b
Include gear on each page of about:addons r=jaws

Comment 5

[Mark Striemer [:mstriemer]]

Comment on attachment 9018396 [details]
Bug 1500165 - Include gear on each page of about:addons r?jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1488730

User impact if declined: The gear menu in about:addons is hidden on some views, like the recent and available updates views.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Moves markup for the gear menu out of list view, closer to where it was before.

String changes made/needed: None

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/56f06760024b

Comment 7

[Julien Cristau [:jcristau]]

IMO this should have some verification if we're going to uplift.  If not from automated tests, then manual QA.

Comment 8

[Paul_B]

I managed to reproduce the issue using version 64.0a1 (20181018123730). Check for updates is not available on the Recent Updates page.

I retested using 65.0a1 (20181105100136) on Windows 10 x64, macOS 10.13.6 and Ubuntu 16.04 x64 and the issue is fixed as the check for updates option is available on the Recent Updates page.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9018396 [details]
Bug 1500165 - Include gear on each page of about:addons r?jaws

about:addons fix, approved for 64.0b8

Comment 10

[Natalia Csoregi [:nataliaCs]]

We encountered a conflict while trying to uplift:

warning: conflicts while merging toolkit/mozapps/extensions/content/extensions.xul! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue

@mstriemer can you please provide a patch for beta? Thank you.

Comment 11

[Mark Striemer [:mstriemer]]

Attachment: 1500165.patch

Comment 12

[Mark Striemer [:mstriemer]]

This patch should work on Beta.

Comment 13

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bf39f03ec712

Comment 14

[Paul_B]

Verified as fixed using DevEdition 64.0b8 (20181108141956) on Windows 10 x64, macOS 10.13.6 and Ubuntu 16.04 x64. The check for updates option is available on the Recent Updates page.