[de-xbl] convert the ruleaction binding (and the filterlistitem binding it is using) to <richlistitem is="ruleaction-richlistitem">
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: arshad, Assigned: khushil324)
References
Details
Attachments
(1 file, 5 obsolete files)
34.84 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 2•6 years ago
|
||
Likely the filterlistitem can just go (workaround for something that would appear not to be the case anymore)
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #4)
Can we remove this now?
Doing so, it is showing this: JavaScript error: chrome://global/content/elements/richlistbox.js, line 422: TypeError: setting getter-only property "selected"
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Actually, we can remove getActionStrings function from ruleaction-richlistitem and directly integrate into showActionsOrder. We just need an array with name of the each action and its argument.
Comment 13•5 years ago
|
||
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 15•5 years ago
|
||
I can't see a try run here. This looks like a larger patch.
Assignee | ||
Comment 16•5 years ago
|
||
Can you push a try run for me ? I am on a different machine and don't have configured key for try push.
Comment 17•5 years ago
|
||
Assignee | ||
Comment 18•5 years ago
|
||
Thanks :)
Assignee | ||
Updated•5 years ago
|
Comment 19•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5496b4328be5
[de-xbl] convert the ruleaction binding to <richlistitem is='ruleaction-richlistitem'>. r=mkmelin DONTBUILD
Updated•5 years ago
|
Description
•