Some Tabs API functions don't work in debug builds

RESOLVED FIXED in Thunderbird 65.0

Status

--
trivial
RESOLVED FIXED
2 months ago
3 days ago

People

(Reporter: neil, Assigned: darktrojan)

Tracking

Thunderbird 65.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago
Debug builds validate the values returned to the extension against the schema.

For instance, the tabs.create API returns Toolkit tab objects to the extension and the properties of this object are validated in debug builds.

However Thunderbird's schema doesn't contain all of the properties that Toolkit sets on tab objects so the validation fails.
(Assignee)

Comment 2

5 days ago
Created attachment 9029735 [details] [diff] [review]
1511838-webext-tab-properties-1.diff

Same patch, different bug.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9029735 - Flags: review?(mkmelin+mozilla)
Attachment #9029735 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

4 days ago
Keywords: checkin-needed

Comment 3

4 days ago
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/c474610d2c81
Stop returning some useless properties in a WebExtensions tab object; r=mkmelin
Status: ASSIGNED → RESOLVED
Last Resolved: 4 days ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Assignee)

Updated

4 days ago
Target Milestone: --- → Thunderbird 65.0
(Reporter)

Comment 4

3 days ago
Thanks!
You need to log in before you can comment on or make changes to this bug.