Closed Bug 1511838 Opened 6 years ago Closed 6 years ago

Fix tabs API for WebExtensions after bug 1500479

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

Product:
Thunderbird
Component:
Add-Ons: Extensions API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 65.0

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: leave-open)

Attachments

(1 file, 1 obsolete file)

Specific fix - Landed
680 bytes, patch
darktrojan
: review+
Details | Diff | Splinter Review 
Bug 1500479 added a new property to the `TabBase` object so Thunderbird needs to add an override for it.

        Attachment #9029301 -
        Flags: review?(geoff)

    
  
Blocks: 1500479

    
    

    
  
Impact:
Without this fix, the tabs API is broken. API calls throw. This breaks our addon completely, you cannot even log in.

    
    

    
  


  
I've a bigger patch, which also prevents things from dying on debug builds.

        Attachment #9029339 -
        Flags: review?(mkmelin+mozilla)

    
    

    
  
Comment on attachment 9029301 [details] [diff] [review]
Specific fix - Landed

Review of attachment 9029301 [details] [diff] [review]:
-----------------------------------------------------------------

Since this is a subset of my patch, it might as well land now.

        Attachment #9029301 -
        Flags: review?(geoff) → review+

    
    

    
  
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b0cfc39adb1e
Fix tabs API for WebExtensions after bug 1500479, part 1. r=darktrojan DONTBUILD
Keywords: checkin-needed

    
    

    
  
Thanks! That fixes the immediate bug for us.

    
  

        Attachment #9029301 -
        Attachment description: Proposed patch → Specific fix - Landed

    
    

    
  
> I've a bigger patch, which also prevents things from dying on debug builds.

Strictly speaking that's bug 1501294...

    
    

    
  
Geoff, should we close this as FIXED and you continue with the patch in bug 1501294?

    
    

    
  
I suppose, now that I know it exists.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0

        Attachment #9029339 -
        Attachment is obsolete: true

        Attachment #9029339 -
        Flags: review?(mkmelin+mozilla)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: