Closed
Bug 1511838
Opened 6 years ago
Closed 6 years ago
Fix tabs API for WebExtensions after bug 1500479
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: neil, Assigned: neil)
References
Details
(Keywords: leave-open)
Attachments
(1 file, 1 obsolete file)
680 bytes,
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
Bug 1500479 added a new property to the `TabBase` object so Thunderbird needs to add an override for it.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9029301 -
Flags: review?(geoff)
Comment 2•6 years ago
|
||
Impact: Without this fix, the tabs API is broken. API calls throw. This breaks our addon completely, you cannot even log in.
Comment 3•6 years ago
|
||
I've a bigger patch, which also prevents things from dying on debug builds.
Attachment #9029339 -
Flags: review?(mkmelin+mozilla)
Comment 4•6 years ago
|
||
Comment on attachment 9029301 [details] [diff] [review] Specific fix - Landed Review of attachment 9029301 [details] [diff] [review]: ----------------------------------------------------------------- Since this is a subset of my patch, it might as well land now.
Attachment #9029301 -
Flags: review?(geoff) → review+
Updated•6 years ago
|
Keywords: checkin-needed,
leave-open
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/b0cfc39adb1e Fix tabs API for WebExtensions after bug 1500479, part 1. r=darktrojan DONTBUILD
Keywords: checkin-needed
Comment 6•6 years ago
|
||
Thanks! That fixes the immediate bug for us.
Updated•6 years ago
|
Attachment #9029301 -
Attachment description: Proposed patch → Specific fix - Landed
Assignee | ||
Comment 7•6 years ago
|
||
> I've a bigger patch, which also prevents things from dying on debug builds. Strictly speaking that's bug 1501294...
Comment 8•6 years ago
|
||
Geoff, should we close this as FIXED and you continue with the patch in bug 1501294?
Comment 9•6 years ago
|
||
I suppose, now that I know it exists.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Updated•6 years ago
|
Attachment #9029339 -
Attachment is obsolete: true
Attachment #9029339 -
Flags: review?(mkmelin+mozilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•