1502070 - Build bustage: Beetmover tasks fail 20181025

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P5)

Description

[Rob Lemley [:rjl]]

Beetmover tasks are failing in the c-c nightlies with errors like:

's3_bucket_path': 'pub/thunderbird/candidates/65.0a1-candidates/build1/'}
2018-10-25 11:10:59,977 - scriptworker.client - ERROR - Failed to run async_main
Traceback (most recent call last):
  File "/builds/scriptworker/lib/python3.6/site-packages/scriptworker/client.py", line 203, in _handle_asyncio_loop
    await async_main(context)
  File "/builds/scriptworker/lib/python3.6/site-packages/beetmoverscript/script.py", line 287, in async_main
    await action_map[context.action](context)
  File "/builds/scriptworker/lib/python3.6/site-packages/beetmoverscript/script.py", line 65, in push_to_nightly
    validate_bucket_paths(context.bucket, mapping_manifest['s3_bucket_path'])
  File "/builds/scriptworker/lib/python3.6/site-packages/beetmoverscript/task.py", line 88, in validate_bucket_paths
    raise ScriptWorkerTaskException("Forbidden S3 {} destination".format(s3_bucket_path))
scriptworker.exceptions.ScriptWorkerTaskException: Forbidden S3 pub/thunderbird/candidates/65.0a1-candidates/build1/ destination


The error doesn't make sense to me though... this is a regular nightly job, it's not a release candidate so why is it trying to put things under candidates/?

Comment 1

[Rob Lemley [:rjl]]

The issue is in https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/taskcluster/taskgraph/decision.py#31-114

This is from Bug 1497575, specifically mozilla-central changeset a0ba1c7ad988. This change adds an entry for 'mozilla-central' to PER_PROJECT_PARAMETERS. We need a corresponding one for 'comm-central'.

This should have been fixed with the port in bug 1501971, but was apparently missed.

Comment 2

[Jorg K (CEST = GMT+2)]

So can you do whatever is required in whichever bug you deem fit?

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1502070 - Add comm-central parameters to decision.py. r=aki

Bug 1497575 added an entry in PER_PROJECT_PARAMETERS for mozilla-central,
this is the corresponding entry for comm-central.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/821f982805ab
Add comm-central parameters to decision.py. r=aki

Comment 5

[Rob Lemley [:rjl]]

scratch my note in comment 1 about bug 1501971... it's incorrect.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/821f982805ab

Comment 7

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/b830f5381a2a