Closed Bug 1502684 Opened Last year Closed Last year

Update common.css textboxes according to photon spec

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: ntim, Assigned: Matthias)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Priority: -- → P3
Assignee: nobody → matthias
Status: NEW → ASSIGNED
I noticed that textboxes are styled with "in-content" variables, which are, afaik, dependent on themes.
Shall I edit the values of the variables or use "hard-coded" photon-variables as var(--grey-90-a50) to style the textboxes accordingly?
Flags: needinfo?(ntim.bugs)
(In reply to :Matthias Kammüller from comment #1)
> I noticed that textboxes are styled with "in-content" variables, which are,
> afaik, dependent on themes.
> Shall I edit the values of the variables or use "hard-coded"
> photon-variables as var(--grey-90-a50) to style the textboxes accordingly?

I think it’d be better to change the in-content variables.
Flags: needinfo?(ntim.bugs)
Attachment #9022653 - Attachment description: Bug 1502684 - photonized text fields.r?ntim,dao → Bug 1502684 - Update in-content textboxes according to photon spec. r=dao
I found out that the xul textboxes use variables as "-moz-Field" for their styling. I would redefine those to be consistent with photon, but they're not defined in common.css
https://searchfox.org/mozilla-central/source/widget/tests/test_platform_colors.xul#62 looked kind of what I was searching for, but I'm not sure.
Do we want to stick to these variables or shall we use grey-90 or maybe introduce a new variable in common.css?
Flags: needinfo?(ntim.bugs)
(In reply to :Matthias Kammüller from comment #4)
> I found out that the xul textboxes use variables as "-moz-Field" for their
> styling. I would redefine those to be consistent with photon, but they're
> not defined in common.css
> https://searchfox.org/mozilla-central/source/widget/tests/
> test_platform_colors.xul#62 looked kind of what I was searching for, but I'm
> not sure.
> Do we want to stick to these variables or shall we use grey-90 or maybe
> introduce a new variable in common.css?

I think color: inherit; would be ok in this case.
Flags: needinfo?(ntim.bugs)
What is the correct way to set -moz-FieldText?
Flags: needinfo?(dao+bmo)
(In reply to :Matthias Kammüller from comment #6)
> What is the correct way to set -moz-FieldText?

You should keep the textbox.css files as they are. To override -moz-FieldText, you can use color: inherit; in common.inc.css.
What Tim said...
Flags: needinfo?(dao+bmo)
Can we push the changes or do you want the other photon-bugs fixed first?
Flags: needinfo?(ntim.bugs)
I tried to land this earlier today but it failed:

"We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpedYP0s
patching file toolkit/themes/shared/in-content/common.inc.css
Hunk #1 FAILED at 14
1 out of 8 hunks FAILED -- saving rejects to file toolkit/themes/shared/in-content/common.inc.css.rej
abort: patch failed to apply', '')"
Flags: needinfo?(ntim.bugs)
Attachment #9022653 - Attachment description: Bug 1502684 - Update in-content textboxes according to photon spec. r=dao → Bug 1502684 - photonized text fields.r=ntim
Attachment #9022653 - Attachment description: Bug 1502684 - photonized text fields.r=ntim → Bug 1502684 - Update in-content textboxes according to photon spec. r=dao
Attachment #9022653 - Attachment description: Bug 1502684 - Update in-content textboxes according to photon spec. r=dao → Bug 1502684 - Update in-content textboxes according to photon spec. r=dao,ntim
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/388921b46651
Update in-content textboxes according to photon spec. r=dao,ntim
https://hg.mozilla.org/mozilla-central/rev/388921b46651
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Depends on: 1510197
Depends on: 1521071
You need to log in before you can comment on or make changes to this bug.