1502684 - Update common.css textboxes according to photon spec

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P3)

Description

[Tim Nguyen :ntim]

https://design.firefox.com/photon/components/input-fields.html

Comment 1

[Matthias :Kammueller]

I noticed that textboxes are styled with "in-content" variables, which are, afaik, dependent on themes.
Shall I edit the values of the variables or use "hard-coded" photon-variables as var(--grey-90-a50) to style the textboxes accordingly?

Comment 2

[Tim Nguyen :ntim]

(In reply to :Matthias Kammüller from comment #1)
> I noticed that textboxes are styled with "in-content" variables, which are,
> afaik, dependent on themes.
> Shall I edit the values of the variables or use "hard-coded"
> photon-variables as var(--grey-90-a50) to style the textboxes accordingly?

I think it’d be better to change the in-content variables.

Comment 3

[Matthias :Kammueller]

Attachment: Bug 1502684 - Update in-content textboxes according to photon spec. r=dao,ntim

Comment 4

[Matthias :Kammueller]

I found out that the xul textboxes use variables as "-moz-Field" for their styling. I would redefine those to be consistent with photon, but they're not defined in common.css
https://searchfox.org/mozilla-central/source/widget/tests/test_platform_colors.xul#62 looked kind of what I was searching for, but I'm not sure.
Do we want to stick to these variables or shall we use grey-90 or maybe introduce a new variable in common.css?

Comment 5

[Tim Nguyen :ntim]

(In reply to :Matthias Kammüller from comment #4)
> I found out that the xul textboxes use variables as "-moz-Field" for their
> styling. I would redefine those to be consistent with photon, but they're
> not defined in common.css
> https://searchfox.org/mozilla-central/source/widget/tests/
> test_platform_colors.xul#62 looked kind of what I was searching for, but I'm
> not sure.
> Do we want to stick to these variables or shall we use grey-90 or maybe
> introduce a new variable in common.css?

I think color: inherit; would be ok in this case.

Comment 6

[Matthias :Kammueller]

What is the correct way to set -moz-FieldText?

Comment 7

[Tim Nguyen :ntim]

(In reply to :Matthias Kammüller from comment #6)
> What is the correct way to set -moz-FieldText?

You should keep the textbox.css files as they are. To override -moz-FieldText, you can use color: inherit; in common.inc.css.

Comment 8

[Dão Gottwald [:dao]]

What Tim said...

Comment 9

[Matthias :Kammueller]

Can we push the changes or do you want the other photon-bugs fixed first?

Comment 10

[Dão Gottwald [:dao]]

I tried to land this earlier today but it failed:

"We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpedYP0s
patching file toolkit/themes/shared/in-content/common.inc.css
Hunk #1 FAILED at 14
1 out of 8 hunks FAILED -- saving rejects to file toolkit/themes/shared/in-content/common.inc.css.rej
abort: patch failed to apply', '')"

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/388921b46651
Update in-content textboxes according to photon spec. r=dao,ntim

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/388921b46651