1502731 - Remove @hudButton@ and @hudButtonPressed@ and improve bookmark panel styling

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Tim Nguyen :ntim]

They're only used in the bookmarks panel and the identity panel, also their styling is outdated.

Their usage could be replaced by a .panel-button class.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1502731 - Remove @hudButton@ and @hudButtonPressed@. r?dao

Comment 2

[Tim Nguyen :ntim]

Hmm, this doesn't look quite right on Linux. I don't really have time to look into why, so feel free to take over this.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1502731 - Modernize MacOS bookmarking panel component styles. r?dao

Depends on D10004

Comment 4

[Tim Nguyen :ntim]

This should now be ready for review.

Comment 5

[Tim Nguyen :ntim]

Note that this shouldn't change the styling on Linux or Windows. It should only affect MacOS.

Although it would be nice to have this styling ported to Linux/Windows too.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98406d23f4e0
Remove @hudButton@ and @hudButtonPressed@. r=dao
https://hg.mozilla.org/integration/autoland/rev/c88acd1ac1b5
Modernize MacOS bookmarking panel component styles. r=dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e80f0318d599
Fix browser_all_files_referenced.js failures. r=me

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/98406d23f4e0
https://hg.mozilla.org/mozilla-central/rev/c88acd1ac1b5
https://hg.mozilla.org/mozilla-central/rev/e80f0318d599

Comment 11

[Tim Nguyen :ntim]

This bug removes toolkit/themes/osx/global/icons/panel-dropmarker.png, which seems to be used by TB.

Comment 12

[Richard Marti (:Paenglab)]

Thank you for the info, Tim.