Make titlebar visibility:hidden but its children visibility:visible with Linux GTK theme

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

As suggested by Dao in https://phabricator.services.mozilla.com/D9671, this technique could allow us to back out bug 1498356 (which was introduced to work around the fact that -moz-window-titlebar and -moz-window-titlebar-maximized introduce margins on either side of the window).

Setting visibility: hidden on the #titlebar, but visibility: visible on its children would mean that we can keep those margins, but we allow any underlying lwtheme textures to show through.
Note that we're already doing this today on Linux, but some patch in bug 1356920 currently moves us away from this. So there isn't really a question whether this technique could work on Linux, and the conservative route here would be not to drop this behavior in the first place.
Priority: -- → P1
Assignee

Updated

8 months ago
No longer blocks: 1356920
Depends on: 1356920
Comment hidden (obsolete)
Assignee

Updated

8 months ago
Assignee: nobody → mconley
Assignee

Comment 3

8 months ago
This allows us to take advantage of the padding that the titlebar gets with the
-moz-window-titlebar / -moz-window-titlebar-maximized, but also allows us to
bypass the background texture applied to it.

We were doing this before, but it got removed in bug 1356920. Bug 1498356 was
originally landed as part of a more elaborate solution to this background texture
problem, and this patch makes bug 1498356 no longer necessary.
Please also back out Bug 1498898 which depends on bug 1498356 and you'll get a build failure without it.
Oops, I accidentally triggered landing of this patch and forgot about the backouts. Shouldn't be a problem since this patch should work regardless. Needinfo mconley to take care of the backouts later.
Flags: needinfo?(mconley)

Comment 7

8 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/377c9cbbb5fa
Hide the visibility of the titlebar when using lightweight themes with the Linux GTK theme. r=dao
Assignee

Comment 8

8 months ago
Once this merges to central, I'll back out bug 1498898 and bug 1498356 on inbound.

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/377c9cbbb5fa
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Summary: Try making titlebar visibility:hidden, but it's children visibility:visible with Linux GTK theme → Make titlebar visibility:hidden but its children visibility:visible with Linux GTK theme
Assignee

Updated

8 months ago
Blocks: 1506248
Assignee

Updated

8 months ago
Flags: needinfo?(mconley)

Updated

7 months ago
Depends on: 1507393
You need to log in before you can comment on or make changes to this bug.