Closed Bug 1506248 Opened 2 years ago Closed 2 years ago

Back out bug 1498898 and bug 1498356 patches, since they're not needed anymore

Categories

(Core :: Widget: Gtk, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(3 files)

Bug 1498898 and bug 1498356 were originally landed as part of a solution to some layout issues while refactoring how we draw tabs in the titlebar.

It turns out that solution wasn't actually required - bug 1503272 made that solution obsolete. We should probably back out the other patches now since they're not needed anymore.
Assignee: nobody → mconley
Depends on: 1503272, 1498356, 1498898
I'm filing a bug and requesting review because enough time has passed since these landed that other patches have landed touching the stuff I'm backing out.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76784596042770017622264c055d05e4b5018049
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42ea9b7ef9c6
Backout bug 1498898 (0a63507e990c) since bug 1503272 makes it unnecessary now. r=stransky
https://hg.mozilla.org/integration/autoland/rev/6e2a207d1e47
Backout bug 1498356 (d2b32aa2055f) since bug 1503272 makes it unnecessary now. r=stransky
https://hg.mozilla.org/integration/autoland/rev/7c2e45e82f07
Backout bug 1498356 (3df978f11b6d) since bug 1503272 makes it unnecessary now. r=stransky
Depends on: 1507423
You need to log in before you can comment on or make changes to this bug.