1508655 - Migrate boxmodel utils out of highlighterutils

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Yulia Startsev [:yulia]]

As part of removing highlighter utils, we should move the boxmodel methods elsewhere

We have some shared functionality with the walker regarding getting the grip. we can either take the same approach as with the node picker, or split this in two parts. Since this is effectively a single function I will likely take the "move it to the fronts" approach.

Comment 1

[Yulia Startsev [:yulia]]

Attachment: Bug 1508655 - BoxModel highlighter split domGrip methods to make them more closely related to the walker; r=ochameau

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1508655 - BoxModel highlighter move nodeHighlighter to highlighterFront; r=ochameau

Depends on D12319

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f67b6fdd714f
BoxModel highlighter split domGrip methods to make them more closely related to the walker; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/5f6b602fb590
BoxModel highlighter move nodeHighlighter to highlighterFront; r=ochameau

Comment 4

[Yulia Startsev [:yulia]]

Attachment: Bug 1508655 - adjust inspector gripToNodeFront funciton

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95a9f538ae4f
"Migrate boxmodel utils out of highlighterutils". r=ochameau CLOSED TREE

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f67b6fdd714f
https://hg.mozilla.org/mozilla-central/rev/5f6b602fb590
https://hg.mozilla.org/mozilla-central/rev/95a9f538ae4f