1504404 - Port bug 1431441 and bug 1504188 to mail/app/nsMailApp.cpp

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/mozilla-central/rev/03cb6cfc053d
https://hg.mozilla.org/mozilla-central/rev/ab19a1589b29

nsMailApp.cpp is diverging. Richard, can you take this one.

Comment 1

[Richard Marti (:Paenglab)]

We don't use the sandbox now, if I'm right. Should we really add this for Mac?

Comment 2

[Jorg K (CEST = GMT+2)]

I think so. The defines |defined(MOZ_CONTENT_SANDBOX)| will turn this into a no-op, but at least we keep the files in sync.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1504404-Mac-sandbox.patch

Hmm, it seems, it's enabled. When I compile it on Mac, I get this error:

 0:44.64 comm/mail/app/thunderbird
 0:44.75 Undefined symbols for architecture x86_64:
 0:44.75   "mozilla::EarlyStartMacSandboxIfEnabled(int, char**, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from:
 0:44.75       _main in nsMailApp.o
 0:44.75 ld: symbol(s) not found for architecture x86_64

Comment 4

[Jorg K (CEST = GMT+2)]

And this:
https://hg.mozilla.org/mozilla-central/rev/03cb6cfc053d#l1.12

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1504404-Mac-sandbox.patch

For Jörg, our Mac specialist. ;-)

With the moz.build part it builds and TB still starts and works on Mac.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9022380 [details] [diff] [review]
1504404-Mac-sandbox.patch

Looks OK, but let's see:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fd4ffca33f44636221005eb40fc7b89b161c6ade

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4e98be4fc0b
Port bug 1431441 and bug 1504188 to mail/app/nsMailApp.cpp. r=jorgk