https://hg.mozilla.org/mozilla-central/rev/03cb6cfc053d https://hg.mozilla.org/mozilla-central/rev/ab19a1589b29 nsMailApp.cpp is diverging. Richard, can you take this one.
We don't use the sandbox now, if I'm right. Should we really add this for Mac?
I think so. The defines |defined(MOZ_CONTENT_SANDBOX)| will turn this into a no-op, but at least we keep the files in sync.
Hmm, it seems, it's enabled. When I compile it on Mac, I get this error: 0:44.64 comm/mail/app/thunderbird 0:44.75 Undefined symbols for architecture x86_64: 0:44.75 "mozilla::EarlyStartMacSandboxIfEnabled(int, char**, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from: 0:44.75 _main in nsMailApp.o 0:44.75 ld: symbol(s) not found for architecture x86_64
Assignee: nobody → richard.marti
For Jörg, our Mac specialist. ;-) With the moz.build part it builds and TB still starts and works on Mac.
Comment on attachment 9022380 [details] [diff] [review] 1504404-Mac-sandbox.patch Looks OK, but let's see: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fd4ffca33f44636221005eb40fc7b89b161c6ade
Attachment #9022380 - Flags: review?(jorgk) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/d4e98be4fc0b Port bug 1431441 and bug 1504188 to mail/app/nsMailApp.cpp. r=jorgk
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.