Closed
Bug 1504404
Opened 6 years ago
Closed 6 years ago
Port bug 1431441 and bug 1504188 to mail/app/nsMailApp.cpp
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: jorgk-bmo, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
3.68 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/03cb6cfc053d
https://hg.mozilla.org/mozilla-central/rev/ab19a1589b29
nsMailApp.cpp is diverging. Richard, can you take this one.
Assignee | ||
Comment 1•6 years ago
|
||
We don't use the sandbox now, if I'm right. Should we really add this for Mac?
Reporter | ||
Comment 2•6 years ago
|
||
I think so. The defines |defined(MOZ_CONTENT_SANDBOX)| will turn this into a no-op, but at least we keep the files in sync.
Assignee | ||
Comment 3•6 years ago
|
||
Hmm, it seems, it's enabled. When I compile it on Mac, I get this error:
0:44.64 comm/mail/app/thunderbird
0:44.75 Undefined symbols for architecture x86_64:
0:44.75 "mozilla::EarlyStartMacSandboxIfEnabled(int, char**, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&)", referenced from:
0:44.75 _main in nsMailApp.o
0:44.75 ld: symbol(s) not found for architecture x86_64
Assignee: nobody → richard.marti
Reporter | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
For Jörg, our Mac specialist. ;-)
With the moz.build part it builds and TB still starts and works on Mac.
Attachment #9022376 -
Attachment is obsolete: true
Attachment #9022380 -
Flags: review?(jorgk)
Reporter | ||
Comment 6•6 years ago
|
||
Comment on attachment 9022380 [details] [diff] [review]
1504404-Mac-sandbox.patch
Looks OK, but let's see:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=fd4ffca33f44636221005eb40fc7b89b161c6ade
Attachment #9022380 -
Flags: review?(jorgk) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d4e98be4fc0b
Port bug 1431441 and bug 1504188 to mail/app/nsMailApp.cpp. r=jorgk
Reporter | ||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•