1504936 - [Wayland] Debian unstable issues (Gtk 3.24)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

> I got a working build with Gtk 3.10 and wayland enabled on Mozilla
> automation, but the result is not exactly stellar... about half the
> time, it deadlocks during startup, and when it doesn't, popups are
> out of place in different ways. Also context menus don't know not to
> overflow outside the screen. Although, my tree is about 10 days old,
> maybe some things have been fixed since then?
> 
> I did apply that. My point, anyways, is that on my Debian unstable
> desktop, enabling the wayland backend caused the issues I mentioned
> above. That's with Gtk+ 3.24. (and firefox built against 3.10)

Comment 1

[Mike Hommey [:glandium]]

I don't think this needs to block shipping wayland support as runtime opt-in in nightly.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Mike, which DE/window manager do you run? I tested debian unstable / gnome-shell on Wayland under VirtualBox and I don't see any issues. And which build do you run? I tested a build produced on Gtk 3.10 (Fedora 20) there.

Comment 3

[Mike Hommey [:glandium]]

https://queue.taskcluster.net/v1/task/fkyfcpE4RUydpFjcCkbyOQ/runs/0/artifacts/public/build/target.tar.bz2 is the build that I tested. DE is Gnome Shell 3.30.1.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mike Hommey [:glandium] from comment #3)
> https://queue.taskcluster.net/v1/task/fkyfcpE4RUydpFjcCkbyOQ/runs/0/
> artifacts/public/build/target.tar.bz2 is the build that I tested. DE is
> Gnome Shell 3.30.1.

I tested this build on Fedora 29 and Debian Unstable and runs even better than my local builds - I guess because of PGO/LTO clang used by Mozilla.

I suspect there's something wrong with gfx side on your box - it may be caused by enabled hw acceleration (layers.acceleration.force-enabled), enabled WebRenderer or some issues by gfx driver itself - afaik Wayland is broken on nvidia cards.

Do you mind to post your about:support here and try a fresh profile?

Comment 5

[Mike Hommey [:glandium]]

So, I can't reproduce the dead-locks anymore, but I can still reproduce the other issues with a fresh profile.

That is:
- context menus overflow on the right and the bottom of the screen (move the window close to the right/bottom edge of the screen, open a context menu close to the edge, and it's only partially displayed). This doesn't happen with X11.
- (new) even better, in some cases where the window is close to the edge of a screen on a dual screen setup, depending on the distance between the window and the edge, half the context menu is only displayed on one screen (meaning, the other half doesn't appear on the second screen where it would be considering its location, although, ideally, it just shouldn't overlap in the first place).
- context menus from the top of the window, as well as the hamburger menu, are offset by a fair amount vertically, and /that/ seems to be due to my dual screen setup where the left screen doesn't start at 0x0. That is, the top of the right screen is higher than the top of the left screen. This particular problem goes away when I align the screens at the top. (this doesn't happen in XWayland)

I'll see if I can take a screencast.

Comment 6

[Mike Hommey [:glandium]]

Oh, by the way, I got a crash when I was switching my screen configuration (didn't happen with my other running (XWayland) Firefox).

Comment 7

[Mike Hommey [:glandium]]

Attachment: Screencast

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Yes, I'm aware of those multi-monitor issues. It's Bug 1423598 and we need to use Gtk 3.24 symbol gdk_window_move_to_rect() to do that properly.

The crash when switching screen config config is interesting. Do you have any reproduction steps or backtrace?

Comment 9

[Mike Hommey [:glandium]]

I was fiddling with my screen setup, removing a screen, adding it back, moving the location of the second relative to the first. I'm not sure at what point it crashed, and I don't seem to have an (unsubmitted) crash report around.

BTW, the shadow on the hamburger menu is somehow much more pronounced on wayland than it is on xwayland. Obnoxiously so.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mike Hommey [:glandium] from comment #9)
> BTW, the shadow on the hamburger menu is somehow much more pronounced on
> wayland than it is on xwayland. Obnoxiously so.

Yes, I can see that - filed as Bug 1505743, Thanks.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mike Hommey [:glandium] from comment #9)
> I was fiddling with my screen setup, removing a screen, adding it back,
> moving the location of the second relative to the first. I'm not sure at
> what point it crashed, and I don't seem to have an (unsubmitted) crash
> report around.

I've just got a downstream report about it with reproduction steps:
https://bugzilla.redhat.com/show_bug.cgi?id=1647776

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Bug 1507475 - crash at display changes - is also fixed.

I think this can be closed as the follow up bugs are filed/fixed.