1505331 - Port bug 1458308 to TB: (update-prefs) Move update prefs out of profile

Status: RESOLVED FIXED

(Thunderbird :: Preferences, task)

Description

[Richard Marti (:Paenglab)]

Do we need this to port?

If yes, https://hg.mozilla.org/mozilla-central/rev/54dd159fd0a6 and https://hg.mozilla.org/mozilla-central/rev/dc4048b0f691 needs to be ported.

The first changset would be no problem to port for me but the second one is too complicated for me. So this should be done by someone with more knowlegde.

Comment 2

[Jorg K (CEST = GMT+2)]

And the removed app.update.enabled here https://hg.mozilla.org/mozilla-central/rev/663e1f142dd4 which we show in the UI:

https://searchfox.org/comm-central/search?q=app.update.enabled&case=false&regexp=false&path=

mail/app/blocklist.xml
168 <pref>app.update.enabled</pref>

Comment 3

[:aceman]

Attachment: 1505331.patch

This would be the mechanical port of the m-c change.
I also added some of the observer infrastructure that Firefox has in the pref page, so that the update code is the same.

I only tested it on Linux, where the new code still does toggle the bool pref app.update.auto based on the choice on the Update tab in Advanced pane.

But the main change should be on Windows, where it needs testing.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9024199 [details] [diff] [review]
1505331.patch

Review of attachment 9024199 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/preferences/advanced.inc.xul
@@ +471,5 @@
>              <separator/>
>              <radiogroup id="updateRadioGroup"
> +                        align="start">
> +              <radio value="true"
> +                     id="autoDesktop"

nit: id first, like Firefox

@@ +476,4 @@
>                       label="&updateAuto.label;"
>                       accesskey="&updateAuto.accesskey;"/>
> +              <radio value="false"
> +                     id="manualDesktop"

for this too

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1505331.patch v1.1

OK, I've turned XUL attributes around as Magnus requested.

I'm not sure how to test this. Here's a try run since M-C have some update tests:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e9e7a8981f917267dee1c48e3de67bee458b5e0b

I suggest to just land it after that and see how updates shape up on Windows.

Comment 6

[Richard Marti (:Paenglab)]

It could be we suffer then like FX with bug 1506371. But it seems a fix is on the way.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ac42d333c20
Port bug 1458308 to TB: (update-prefs) Move update prefs out of profile. r=jorgk,mkmelin