1507086 - Port bug 1506371 to TB: Updating via Help > About broken on Nightly

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Richard Marti (:Paenglab)]

We need to patch this before we build a Daily to not get the same bug as 1506371 on FX.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1507086-update.patch

Direct port of https://hg.mozilla.org/integration/mozilla-inbound/rev/0d856ddbfc64

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9024961 [details] [diff] [review]
1507086-update.patch

Can you land with DONTBUILD before 11:00?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8882026b926a
Port bug 1506371 to TB: Updating via Help > About broken on Nightly. r=jorgk DONTBUILD

Comment 4

[Richard Marti (:Paenglab)]

Hmm, I see this error now:  ReferenceError: reference to undefined property "promiseAutoUpdateSetting"[Learn More] aboutDialog-appUpdater.js:28:3 

I need to wait until FX updates to check, if FX has the same error. It was a 1 to 1 port, so FX should have this too.

Comment 5

[Jorg K (CEST = GMT+2)]

Any news on this?

The browser/base and mail/base versions of appUpdater() are quite different. I also don't understand what
https://hg.mozilla.org/comm-central/rev/8882026b926a#l1.13
-  this.promiseAutoUpdateSetting = null;
+  this.promiseAutoUpdateSetting;
is meant to do.

Geoff, can you please take a look. By the looks of it most of the differences in the two files will go away after linting the mail version.

Comment 6

[Richard Marti (:Paenglab)]

From bug 1506371 comment 15:
  (In reply to Richard Marti (:Paenglab) from comment #14)
  > When I open the About Firefox dialog, I get:  ReferenceError: reference to
  > undefined property "promiseAutoUpdateSetting"[Learn More]
  > aboutDialog-appUpdater.js:43:3

  Thanks, I'll take care of that in bug 1506915 since I'll have to update the call sites.

Maybe we can wait for the fix in bug 1506915.

Comment 7

[Geoff Lankow (:darktrojan)]

I don't have anything to add here. The file has now been linted. That "this.promiseAutoUpdateSetting;" doesn't make any sense, and should be removed, yet it still exists in m-c. Not our problem, I guess.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bfe80ab94c12
Follow-up: Comment out nonsensical still present in M-C. r=me

Comment 9

[Jorg K (CEST = GMT+2)]

Oops: Comment out nonsensical *line* still present in M-C. r=me

Comment 10

[Jorg K (CEST = GMT+2)]

Looks like they wanted to assign null, see:
https://hg.mozilla.org/mozilla-central/rev/4939e4a1cc20#l2.12