Port bug 1506371 to TB: Updating via Help > About broken on Nightly

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 65.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We need to patch this before we build a Daily to not get the same bug as 1506371 on FX.
Direct port of https://hg.mozilla.org/integration/mozilla-inbound/rev/0d856ddbfc64
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9024961 - Flags: review?(jorgk)
Comment on attachment 9024961 [details] [diff] [review]
1507086-update.patch

Can you land with DONTBUILD before 11:00?
Attachment #9024961 - Flags: review?(jorgk) → review+
Pushed by richard.marti@gmail.com:
https://hg.mozilla.org/comm-central/rev/8882026b926a
Port bug 1506371 to TB: Updating via Help > About broken on Nightly. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Hmm, I see this error now:  ReferenceError: reference to undefined property "promiseAutoUpdateSetting"[Learn More] aboutDialog-appUpdater.js:28:3 

I need to wait until FX updates to check, if FX has the same error. It was a 1 to 1 port, so FX should have this too.
Any news on this?

The browser/base and mail/base versions of appUpdater() are quite different. I also don't understand what
https://hg.mozilla.org/comm-central/rev/8882026b926a#l1.13
-  this.promiseAutoUpdateSetting = null;
+  this.promiseAutoUpdateSetting;
is meant to do.

Geoff, can you please take a look. By the looks of it most of the differences in the two files will go away after linting the mail version.
Flags: needinfo?(geoff)
From bug 1506371 comment 15:
  (In reply to Richard Marti (:Paenglab) from comment #14)
  > When I open the About Firefox dialog, I get:  ReferenceError: reference to
  > undefined property "promiseAutoUpdateSetting"[Learn More]
  > aboutDialog-appUpdater.js:43:3

  Thanks, I'll take care of that in bug 1506915 since I'll have to update the call sites.

Maybe we can wait for the fix in bug 1506915.
I don't have anything to add here. The file has now been linted. That "this.promiseAutoUpdateSetting;" doesn't make any sense, and should be removed, yet it still exists in m-c. Not our problem, I guess.
Flags: needinfo?(geoff)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/bfe80ab94c12
Follow-up: Comment out nonsensical still present in M-C. r=me
Oops: Comment out nonsensical *line* still present in M-C. r=me
Looks like they wanted to assign null, see:
https://hg.mozilla.org/mozilla-central/rev/4939e4a1cc20#l2.12
You need to log in before you can comment on or make changes to this bug.